Skip to content

test: remove unnecessary semver calls #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2025
+521 −627
Merged

test: remove unnecessary semver calls #2985

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e00d49a
test: remove unnecessary `semver` calls
9romise Nov 28, 2025
f60ceb4
more
9romise Nov 28, 2025
1b3062a
chore: remove unneeded code
9romise Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
256 changes: 121 additions & 135 deletions tests/lib/rules/component-name-in-template-casing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
'use strict'

const rule = require('../../../lib/rules/component-name-in-template-casing')
const semver = require('semver')
const RuleTester = require('../../eslint-compat').RuleTester

const tester = new RuleTester({
Expand Down Expand Up @@ -218,42 +217,36 @@ tester.run('component-name-in-template-casing', rule, {
},

// type-only imports
...(semver.gte(
require('@typescript-eslint/parser/package.json').version,
'5.0.0'
)
? [
{
code: `
<script setup lang="ts">
import type Foo from './Foo.vue'
import type { HelloWorld1 } from './components/HelloWorld'
import { type HelloWorld2 } from './components/HelloWorld2'
import type { HelloWorld as HelloWorld3 } from './components/HelloWorld3'
import { type HelloWorld as HelloWorld4 } from './components/HelloWorld4';
import { type default as HelloWorld5 } from './components/HelloWorld5';
import { type Component } from 'vue';
</script>

<template>
<foo />
<hello-world1 />
<hello-world2 />
<hello-world3 />
<hello-world4 />
<hello-world5 />
<component />
</template>
`,
options: ['PascalCase', { registeredComponentsOnly: true }],
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
}
}
]
: [])
{
code: `
<script setup lang="ts">
import type Foo from './Foo.vue'
import type { HelloWorld1 } from './components/HelloWorld'
import { type HelloWorld2 } from './components/HelloWorld2'
import type { HelloWorld as HelloWorld3 } from './components/HelloWorld3'
import { type HelloWorld as HelloWorld4 } from './components/HelloWorld4';
import { type default as HelloWorld5 } from './components/HelloWorld5';
import { type Component } from 'vue';
</script>

<template>
<foo />
<hello-world1 />
<hello-world2 />
<hello-world3 />
<hello-world4 />
<hello-world5 />
<component />
</template>
`,
options: ['PascalCase', { registeredComponentsOnly: true }],
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
}
}
],
invalid: [
{
Expand Down Expand Up @@ -1305,106 +1298,99 @@ tester.run('component-name-in-template-casing', rule, {
]
},
// type-only imports
...(semver.gte(
require('@typescript-eslint/parser/package.json').version,
'5.0.0'
)
? [
{
code: `
<script setup lang="ts">
import type Foo from './Foo.vue'
import type { HelloWorld1 } from './components/HelloWorld'
import { type HelloWorld2 } from './components/HelloWorld2'
import type { HelloWorld as HelloWorld3 } from './components/HelloWorld3'
import { type HelloWorld as HelloWorld4 } from './components/HelloWorld4';
import { type default as HelloWorld5 } from './components/HelloWorld5';
import { type Component } from 'vue';
</script>
{
code: `
<script setup lang="ts">
import type Foo from './Foo.vue'
import type { HelloWorld1 } from './components/HelloWorld'
import { type HelloWorld2 } from './components/HelloWorld2'
import type { HelloWorld as HelloWorld3 } from './components/HelloWorld3'
import { type HelloWorld as HelloWorld4 } from './components/HelloWorld4';
import { type default as HelloWorld5 } from './components/HelloWorld5';
import { type Component } from 'vue';
</script>

<template>
<foo />
<hello-world1 />
<hello-world2 />
<hello-world3 />
<hello-world4 />
<hello-world5 />
<component />
</template>
`,
options: ['PascalCase', { registeredComponentsOnly: false }],
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
output: `
<script setup lang="ts">
import type Foo from './Foo.vue'
import type { HelloWorld1 } from './components/HelloWorld'
import { type HelloWorld2 } from './components/HelloWorld2'
import type { HelloWorld as HelloWorld3 } from './components/HelloWorld3'
import { type HelloWorld as HelloWorld4 } from './components/HelloWorld4';
import { type default as HelloWorld5 } from './components/HelloWorld5';
import { type Component } from 'vue';
</script>
<template>
<foo />
<hello-world1 />
<hello-world2 />
<hello-world3 />
<hello-world4 />
<hello-world5 />
<component />
</template>
`,
output: `
<script setup lang="ts">
import type Foo from './Foo.vue'
import type { HelloWorld1 } from './components/HelloWorld'
import { type HelloWorld2 } from './components/HelloWorld2'
import type { HelloWorld as HelloWorld3 } from './components/HelloWorld3'
import { type HelloWorld as HelloWorld4 } from './components/HelloWorld4';
import { type default as HelloWorld5 } from './components/HelloWorld5';
import { type Component } from 'vue';
</script>

<template>
<Foo />
<HelloWorld1 />
<HelloWorld2 />
<HelloWorld3 />
<HelloWorld4 />
<HelloWorld5 />
<component />
</template>
`,
errors: [
{
message: 'Component name "foo" is not PascalCase.',
line: 13,
column: 17,
endLine: 13,
endColumn: 21
},
{
message: 'Component name "hello-world1" is not PascalCase.',
line: 14,
column: 17,
endLine: 14,
endColumn: 30
},
{
message: 'Component name "hello-world2" is not PascalCase.',
line: 15,
column: 17,
endLine: 15,
endColumn: 30
},
{
message: 'Component name "hello-world3" is not PascalCase.',
line: 16,
column: 17,
endLine: 16,
endColumn: 30
},
{
message: 'Component name "hello-world4" is not PascalCase.',
line: 17,
column: 17,
endLine: 17,
endColumn: 30
},
{
message: 'Component name "hello-world5" is not PascalCase.',
line: 18,
column: 17,
endLine: 18,
endColumn: 30
}
]
}
]
: [])
<template>
<Foo />
<HelloWorld1 />
<HelloWorld2 />
<HelloWorld3 />
<HelloWorld4 />
<HelloWorld5 />
<component />
</template>
`,
options: ['PascalCase', { registeredComponentsOnly: false }],
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
{
message: 'Component name "foo" is not PascalCase.',
line: 13,
column: 11,
endLine: 13,
endColumn: 15
},
{
message: 'Component name "hello-world1" is not PascalCase.',
line: 14,
column: 11,
endLine: 14,
endColumn: 24
},
{
message: 'Component name "hello-world2" is not PascalCase.',
line: 15,
column: 11,
endLine: 15,
endColumn: 24
},
{
message: 'Component name "hello-world3" is not PascalCase.',
line: 16,
column: 11,
endLine: 16,
endColumn: 24
},
{
message: 'Component name "hello-world4" is not PascalCase.',
line: 17,
column: 11,
endLine: 17,
endColumn: 24
},
{
message: 'Component name "hello-world5" is not PascalCase.',
line: 18,
column: 11,
endLine: 18,
endColumn: 24
}
]
}
]
})
88 changes: 40 additions & 48 deletions tests/lib/rules/no-boolean-default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/
'use strict'

const semver = require('semver')
const rule = require('../../../lib/rules/no-boolean-default')

const RuleTester = require('../../eslint-compat').RuleTester
Expand Down Expand Up @@ -484,15 +483,9 @@ ruleTester.run('no-boolean-default', rule, {
}
]
},
...(semver.lt(
require('@typescript-eslint/parser/package.json').version,
'4.0.0'
)
? []
: [
{
filename: 'test.vue',
code: `
{
filename: 'test.vue',
code: `
<script setup lang="ts">
interface Props {
foo: boolean
Expand All @@ -502,26 +495,26 @@ ruleTester.run('no-boolean-default', rule, {
})
</script>
`,
languageOptions: {
parser: require('vue-eslint-parser'),
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
{
message:
'Boolean prop should not set a default (Vue defaults it to false).',
line: 7,
column: 14,
endLine: 7,
endColumn: 19
}
]
},
{
filename: 'test.vue',
code: `
languageOptions: {
parser: require('vue-eslint-parser'),
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
{
message:
'Boolean prop should not set a default (Vue defaults it to false).',
line: 7,
column: 14,
endLine: 7,
endColumn: 19
}
]
},
{
filename: 'test.vue',
code: `
<script setup lang="ts">
interface Props {
foo: boolean
Expand All @@ -531,24 +524,23 @@ ruleTester.run('no-boolean-default', rule, {
})
</script>
`,
languageOptions: {
parser: require('vue-eslint-parser'),
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
options: ['default-false'],
errors: [
{
message: 'Boolean prop should only be defaulted to false.',
line: 7,
column: 14,
endLine: 7,
endColumn: 18
}
]
}
]),
options: ['default-false'],
languageOptions: {
parser: require('vue-eslint-parser'),
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
{
message: 'Boolean prop should only be defaulted to false.',
line: 7,
column: 14,
endLine: 7,
endColumn: 18
}
]
},
{
filename: 'test.vue',
code: `
Expand Down
Loading
Loading