Bug fix for TableView tooltip #5158
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1)
Line range hint
186-202: Consider performance and type safety improvementsThe tooltip implementation could benefit from the following enhancements:
- Memoize tooltip components to prevent unnecessary re-renders
- Add proper TypeScript types for tooltip data
Consider these improvements:
// Add at the top of the file interface TooltipData { value: string; row: number; column: number; } // Memoize the tooltip cell content const TooltipContent = React.memo(({ content, tooltip }: { content: React.ReactNode; tooltip: string }) => ( <Tooltip title={tooltip} arrow aria-label={`Additional information: ${tooltip}`}> <span>{content}</span> </Tooltip> ));Then update the cell rendering:
{tooltip ? ( - <Tooltip title={tooltip} arrow> - <span> {content} </span> - </Tooltip> + <TooltipContent content={content} tooltip={tooltip} /> ) : (content)}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/TableView.tsx(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx
🧰 Additional context used
📓 Path-based instructions (1)
app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
🔇 Additional comments (1)
app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1)
186-186: LGTM! Good refactoring for readability
The introduction of the content variable improves code readability by avoiding repeated formatCellValue calls and follows React best practices by computing values before JSX.
| <span> {content} </span> | ||
| </Tooltip> | ||
| ) : ( | ||
| formatCellValue(item[key], props) // No Tooltip for cells without tooltips | ||
| )} | ||
| ) : (content)} |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve tooltip implementation
The current implementation has several issues:
- Extra whitespace in
<span> {content} </span>will be rendered as padding - The span wrapper might be unnecessary
- Missing accessibility attributes for better screen reader support
Consider applying these improvements:
- <span> {content} </span>
+ <span>{content}</span>Also, enhance accessibility by adding aria attributes to the Tooltip:
- <Tooltip title={tooltip} arrow>
+ <Tooltip
+ title={tooltip}
+ arrow
+ aria-label={`Additional information: ${tooltip}`}
+ >Committable suggestion skipped: line range outside the PR's diff.
* Single child for tooltip --------- Co-authored-by: minhtuevo <[email protected]>
* Single child for tooltip --------- Co-authored-by: minhtuevo <[email protected]>
* Single child for tooltip --------- Co-authored-by: minhtuevo <[email protected]>
What changes are proposed in this pull request?
In teams, Tooltip cannot handle multiple children at once and thus causing error
How is this patch tested? If it is not, please explain why.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changesSummary by CodeRabbit
Improvements
TableViewcomponent by simplifying cell content rendering and tooltip management.Refactor
ActionsMenucomponent to streamline the code while maintaining existing functionality.