Bug fix for TableView tooltip (#5158)

[minhtuev]

• Single child for tooltip

---

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• New Features

  • Improved rendering logic in the TableView component for clearer display of cell content.
  • Simplified tooltip behavior for better user experience.

• Bug Fixes

  • Adjusted spacing around tooltip content for consistent formatting.

• Refactor

  • Streamlined the rendering process in both ActionsMenu and TableView components for enhanced clarity.

[coderabbitai]

Walkthrough

The changes consist of modifications to the ActionsMenu and TableView components. In ActionsMenu.tsx, a comment was removed from the Action function without altering the component's logic or functionality. In TableView.tsx, the rendering logic was streamlined by introducing a variable to format cell content, simplifying tooltip handling, and improving spacing. These changes enhance code clarity while maintaining existing functionality across both components.

Changes

File Path	Change Summary
app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx	Removed a comment in the Action function related to the Tooltip component. No functional changes made.
app/packages/core/src/plugins/SchemaIO/components/TableView.tsx	Adjusted rendering logic for TableCell components by introducing a content variable for formatted values. Simplified tooltip wrapping logic and improved spacing.

Possibly related PRs

• Update TableView with multi inline actions #5118: The changes in this PR enhance the TableView component by allowing multiple inline actions, which directly relates to the modifications made in the main PR regarding the ActionsMenu component.
• Tooltip support for TableView actions #5142: This PR introduces tooltip support for actions within the TableView, which aligns with the main PR's focus on the ActionsMenu component and its rendering logic.
• Add support for cell tooltip in TableView #5152: The addition of tooltip functionality for cells in the TableView is directly relevant to the changes in the main PR, which also involves tooltip management in the ActionsMenu.
• Bug fix for TableView tooltip #5158: This PR addresses a bug related to tooltip functionality in the TableView, which is pertinent to the overall context of tooltip handling discussed in the main PR.

Suggested labels

app

Suggested reviewers

• CamronStaley
• ritch

🐇 In the code where comments once lay,
The rabbit hops, clearing the way.
With tooltips now light, and cells shining bright,
The table's a dance, a joyful sight!
Let's celebrate changes, both simple and grand,
In our code garden, together we stand! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1)

186-186: Improve tooltip text spacing.

The content extraction and conditional rendering look good. However, the extra spaces in the tooltip span wrapper could affect text alignment.

Consider removing the extra spaces:

-              <span> {content} </span>
+              <span>{content}</span>

Also applies to: 200-202

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9967d21 and 4a9c654.

📒 Files selected for processing (2)

• app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx (1 hunks)
• app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx

🧰 Additional context used

📓 Path-based instructions (1)

app/packages/core/src/plugins/SchemaIO/components/TableView.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.