Bug fix for TableView tooltip (#5158)

* Single child for tooltip --------- Co-authored-by: minhtuevo <[email protected]>
voxel51 · Nov 20, 2024 · 9625027 · 9625027
1 parent 657419b
commit 9625027
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx b/app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx
@@ -114,8 +114,7 @@ function Action(props: ActionPropsType) {
 
   return tooltip ? (
     <Tooltip title={tooltip}>
-      <span>{content}</span>{" "}
-      {/* Use <span> to wrap the child to avoid DOM issues */}
+      <span>{content}</span>
     </Tooltip>
   ) : (
     content

diff --git a/app/packages/core/src/plugins/SchemaIO/components/TableView.tsx b/app/packages/core/src/plugins/SchemaIO/components/TableView.tsx
@@ -183,7 +183,7 @@ export default function TableView(props: ViewPropsType) {
                         selectedColumns.has(columnIndex);
 
                       const tooltip = tooltipMap[coordinate]; // Check if there's a tooltip for the cell
-
+                      const content = formatCellValue(item[key], props);
                       const cell = (
                         <TableCell
                           key={key}
@@ -197,11 +197,9 @@ export default function TableView(props: ViewPropsType) {
                         >
                           {tooltip ? (
                             <Tooltip title={tooltip} arrow>
-                              <span>{formatCellValue(item[key], props)}</span> {/* Wrap content with Tooltip */}
+                              <span> {content} </span>
                             </Tooltip>
-                          ) : (
-                            formatCellValue(item[key], props) // No Tooltip for cells without tooltips
-                          )}
+                          ) : (content)}
                         </TableCell>
                       );