Repository navigation
Conversation
Signed-off-by: Yamini Preethi Kamisetty <YaminiPreethi.Kamisetty@amd.com>
|
FYI: #62712 hits this on CI now that its MiniMax model tests run under LBHNC + AITER |
|
This pull request has merge conflicts that must be resolved before it can be |
|
We hit the same assertion with MiniMax-M3.1-Flash on MI355X: the released |
Overview
MiniMax-M3 LBHNC interleaves K and V inside each block, so the V cache view has fewer rows than K. AITER
pa_decode_gluonrequires those leading dimensions to match and fails on the sparse decode path.Claims
_run_gluon_decodenow passes one page count topa_decode_gluonby trimming K to V's length.127 * 16 + 7 = 2039)._run_gluon_decode, so_sides_are_packedandminimax_m3_sparse_block_page_stridestill see the original shapes and keep a block page stride of 16.Validation
Reproduced on MiniMax-M3 with the AITER sparse paged-attention decode path. Before the change, K and V enter the kernel as:
pa_decode_gluonasserts the two leading dimensions match, so this fails even though every page id addresses both tensors.Server Command to run
Accuracy test passes after this fix:
Details
LBHNC places a token's V pages a fixed half-block after its K pages. The gluon decode kernel carries one page id and applies it to both caches, so V's view is rebased by that half-block and is shorter than K. Using V's length for both the cache views and the FP8 scale arguments satisfies the kernel without changing the stride logic that reads the untrimmed shapes.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.