Repository navigation
[ROCm][Perf] Fix wvSplitK tile choice for N>=5 on gfx950 and add N=6 - #62846
Closed
jiacao-amd wants to merge 1 commit into
Closed
jiacao-amd wants to merge 1 commit into
jiacao-amd wants to merge 1 commit into
Conversation
On gfx950 the YTILE 3/4 tiles picked for wide outputs are up to 4x slower than YTILE 2 once N >= 5 (386 vs 95 us for an LM head shard, M=50016, K=6144, N=5), which made N=5 slower than hipBLASLt. Use YTILE 2 there, and let gfx950 also run N=6 on the shapes where it beats hipBLASLt. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: jiacao-amd <jiahui.cao@amd.com>
jiacao-amd
force-pushed
the
rocm-wvsplitk-n5-wide-gfx950
branch
from
October 21, 2026 21:13
b3e04a5 to
3df228c
Compare
6 tasks done
This was referenced Oct 24, 2026
Contributor
Author
|
Closing: on MiniMax-M3.1-Flash (the target now) decode batches never hit the N=5/6 wvSplitK path, and the related lm_head dispatch change measured only ~0.6% end to end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
On gfx950,
wvSplitKpicks YTILE 3 or 4 for wide outputs. Once N >= 5 those tiles are up to 4x slower than YTILE 2, so N=5 fell behind hipBLASLt on shapes like an LM head shard (e.g. the draft/target LM head under EAGLE with K=3 and 5 rows).This PR:
wvSplitKwhere it beats hipBLASLt (M > 1024, 2048 <= K <= 8192).Kernel results (MI355X, bf16, µs per call, CUDA graph over rotating weights)
LM head shard M=50016, K=6144:
Over a 630-shape grid (M 16–100032, K 512–16384, N 1–6):
Max relative error vs an fp32 reference: 0.4%.
E2E (MI355X, MiniMax-M3-MXFP4, TP4, EAGLE3 K=3)
vLLM nightly
8e2beaa3(AITER v0.1.26) plus #61889, which that nightly needs to start MiniMax-M3; the baseline is the same image without this PR. AgenticX: InferenceX recipeminimaxm3/vllm/mi355x-fp4-mtp/agentic.yaml, 3600 s per point, one run each (run-to-run noise is about ±3%). Cells are baseline → this PR.AgenticX (selected points; also measured: the previous revision at TP2 C1–C16)
The change applies when the draft LM head runs with 5 or 6 rows, about a quarter of the time at C20–C24 and less at higher concurrency, which matches the 1–2.5% lower TPOT.
Accuracy (GSM8K), InferenceX
gsm8k.yaml, 5-shot, all 1,319 questions, real EAGLE3 acceptance, thinking on:Standard error ±0.53%.
Test plan
tests/model_executor/layers/test_rocm_unquantized_gemm.py: new dispatch cases for N=5/6/7 on gfx950 and other gfx9 (42 passed, 2 skipped on MI355X).wvSplitKand hipBLASLt.🤖 Generated with Claude Code