Repository navigation
[Build] Update deep_gemm git pin to fix ambiguous calls in torch>=2.14 - #61700
cleonard530 wants to merge 7 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
This pull request has merge conflicts that must be resolved before it can be |
|
can we use |
|
@khluu, yes that's the plan. Once someone merges the PR vllm-project/DeepGEMM#37 then we can update this PR to point to that new commit. |
Harry-Chen
changed the title
|
✅ @cleonard530, CI is now available for this PR.
|
|
/ci run |
|
✅ Triggered Buildkite CI #95072 for commit |
|
/ci run |
|
✅ Triggered Buildkite CI #95077 for commit |
Signed-off-by: Chris Leonard <chleonar@redhat.com>
Signed-off-by: Chris Leonard <chleonar@redhat.com>
09b3313 to
0636e0a
Compare
|
/ci run |
|
✅ Triggered Buildkite CI #95110 for commit ℹ️ This PR is 1 commit behind upstream |
Signed-off-by: Chris Leonard <chleonar@redhat.com>
|
/ci run |
|
✅ Triggered Buildkite CI #95112 for commit |
There was a problem hiding this comment.
please don't update this as the file is unused and we're going to remove it - see #61265 where I've already had to resolve a... surprising number of merge conflicts due to bumps and reverts of deepgemm
There was a problem hiding this comment.
@tlrmchlsmth, sorry about the reverts of deepgemm. If I remove the install_deepgemm.sh file from this PR, will it be fine to merge (assuming the CI passes again)?
There was a problem hiding this comment.
Also, I could just combine your PR with this one if that works for you?
There was a problem hiding this comment.
Aright, I just reverted the install_deepgemm.sh updates here. I didn't include your other updates.
Signed-off-by: Chris Leonard <chleonar@redhat.com>
|
/ci run |
|
✅ Triggered Buildkite CI #95202 for commit ℹ️ This PR is 1 commit behind upstream |
|
This pull request has merge conflicts that must be resolved before it can be |
|
This PR already updated the git tag so it doesn't look like this is needed anymore https://github.com/vllm-project/vllm/pull/61744/changes. @tlrmchlsmth, looks like they updated |
|
Superceded by #61744 |
Overview
Update git tag for DeepGEMM.
The updated DeepGEMM (see vllm-project/DeepGEMM#37) fixes build errors due to ambiguous calls in torch >= 2.14 (
bitwise_and,bitwise_or, etc.).Validation
Rebuilt vllm pointing to this commit with torch 2.14.1. It didn't work before the commit and is working now.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.