Repository navigation
[Build] Update deep_gemm git pin to fix ambiguous calls in torch>=2.14 #61700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
cleonard530
wants to merge
7
commits into
vllm-project:main
from
cleonard530:git_tag_for_fix_ambiguous_torch_calls
Closed
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
83dcffd
update deep_gemm git pin to fix amibiguous calls in torch>=2.14
cleonard530 0636e0a
remove deep_gemm from torch-check-abi
cleonard530 bae9c93
Merge branch 'main' into git_tag_for_fix_ambiguous_torch_calls
khluu 9dd5345
forgot to update remote repo name
cleonard530 10dd289
removing install_deepgemm update from PR
cleonard530 02b70df
Merge branch 'main' into git_tag_for_fix_ambiguous_torch_calls
cleonard530 0ab4ea2
Merge branch 'main' into git_tag_for_fix_ambiguous_torch_calls
khluu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't update this as the file is unused and we're going to remove it - see #61265 where I've already had to resolve a... surprising number of merge conflicts due to bumps and reverts of deepgemm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tlrmchlsmth, sorry about the reverts of deepgemm. If I remove the install_deepgemm.sh file from this PR, will it be fine to merge (assuming the CI passes again)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I could just combine your PR with this one if that works for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both are OK by me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aright, I just reverted the install_deepgemm.sh updates here. I didn't include your other updates.