[Build] Update deep_gemm git tag for locality_domain update by cleonard530 · Pull Request #61491 · vllm-project/vllm

cleonard530 · 2026-10-13T20:03:43Z

Overview

Update DeepGEMM to the top of this PR vllm-project/DeepGEMM#35.

The current DeepGEMM pin computes balanced SM locality domains during deep_gemm initialization. On a 60-SM MIG device, that reaches an existing balancing error during vLLM import, even when locality features are unused (see #59482 (comment)). This PR updates both the CMake dependency and standalone installer to cleonard530/DeepGEMM@6af2d3a, which restores lazy C++ locality initialization using stable PyTorch APIs.
~~The legacy balancing issue remains and can still surface when balanced locality domains are requested.~~

cc @Harry-Chen @janeyx99 @khluu

Pull Request Checklist

I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).
AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

claude

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

mergify · 2026-10-13T22:51:15Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @cleonard530.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

njhill · 2026-10-14T03:02:04Z

/ci run

github-actions · 2026-10-14T03:02:23Z

❌ This PR is 2 commits behind upstream main. Your branch must contain every commit currently on upstream main. No new CI build was started. Merge or rebase onto the latest main, then rerun /ci run. To test this branch at your own risk, use /ci run --allow-stale.

njhill · 2026-10-14T03:02:49Z

/ci run --allow-stale

github-actions · 2026-10-14T03:03:08Z

✅ Triggered Buildkite CI #94658 for commit 33262369f610.

⚠️ This PR is 2 commits behind upstream main. Running CI at your own risk because --allow-stale was requested; outdated CI configuration may cause failures. Before merging, merge or rebase onto the latest main, then rerun /ci run on the latest PR commit.

janeyx99

Seeing if I can update the PR with comments

cleonard530 · 2026-10-14T03:08:23Z

Thanks for running this @njhill, but the PR that this was pointing to just got merged so I'm going to update it the the vllm fork instead of my own. Can you rerun it again after that, or add the ready tag and I can rerun it?

Signed-off-by: Chris Leonard <chleonar@redhat.com>

github-actions · 2026-10-14T03:12:36Z

✅ @cleonard530, CI is now available for this PR.

/ci run starts upstream CI; /amd-ci run starts AMD CI only.
Your branch must contain every commit currently on its upstream target branch. Merge or rebase onto the latest target branch, then rerun the command. Append --allow-stale to a run command to test an outdated branch at your own risk.
/ci retry retries failed jobs in the CI build for the current PR head. If the current head has no CI build, it starts a new CI build for the current head containing only jobs that failed in the latest earlier CI build for this PR.
/amd-ci retry retries failed jobs in AMD CI for the current PR head. Use /amd-ci run when the current head has no AMD CI build.
/ci cancel cancels scheduled or running CI builds for this PR branch; /amd-ci cancel does the same for AMD CI only.

njhill · 2026-10-14T03:12:44Z

/ci run

github-actions · 2026-10-14T03:13:04Z

✅ Triggered Buildkite CI #94660 for commit 2a29cc5ba466.

Signed-off-by: Shengqi Chen <harry-chen@outlook.com>

Harry-Chen · 2026-10-14T04:00:42Z

/ci run

github-actions · 2026-10-14T04:01:02Z

✅ Triggered Buildkite CI #94667 for commit 1c8ba6bfc326.

Harry-Chen

LGTM. Sorry for the CI breakage in the previous PR.

cleonard530 · 2026-10-14T21:26:27Z

FYI, @Harry-Chen, @ywang96, @janeyx99. I did find another bug. If torch >= 2.14, then there are ambiguous calls in DeepGEMMs torch_compat.hpp. This is easy to fix though, and the PRs to fix this are vllm-project/DeepGEMM#37 and #61700

khluu · 2026-10-14T22:01:33Z

Hi @cleonard530 @Harry-Chen can we land this PR again after testing with torch 2.14? The CI in this PR ran before torch 2.14 upgrade, so it merged and clashed with torch 2.14 upgrade on main (landed like 12 hours ago) and caused all image build on CI to fail. More details here https://vllm-dev.slack.com/archives/C07R5PAL2L9/p1792014117298589.

Sorry about this

…ject#61491) Signed-off-by: Chris Leonard <chleonar@redhat.com> Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Co-authored-by: Shengqi Chen <harry-chen@outlook.com> Signed-off-by: Andreas Karatzas <AndreasKaratzas@users.noreply.github.com>

…ject#61491) Signed-off-by: Chris Leonard <chleonar@redhat.com> Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Co-authored-by: Shengqi Chen <harry-chen@outlook.com>

cleonard530 requested review from Harry-Chen, LucasWilkinson and tlrmchlsmth as code owners October 13, 2026 20:03

claude Bot reviewed Oct 13, 2026

View reviewed changes

mergify Bot added the ci/build label Oct 13, 2026

mergify Bot added the needs-rebase label Oct 13, 2026

cleonard530 force-pushed the update_deep_gemm_tag_for_locality_domain_update branch from 8ff3441 to 3326236 Compare October 14, 2026 02:25

mergify Bot removed the needs-rebase label Oct 14, 2026

janeyx99 reviewed Oct 14, 2026

View reviewed changes

Comment thread cmake/external_projects/deepgemm.cmake Outdated

Comment thread cmake/external_projects/deepgemm.cmake Outdated

Comment thread tools/install_deepgemm.sh Outdated

Comment thread tools/install_deepgemm.sh Outdated

cleonard530 added 3 commits October 14, 2026 03:11

update deep_gemm git tag for locality_domain update

0a618e4

Signed-off-by: Chris Leonard <chleonar@redhat.com>

update deep_gemm git tag

2ea176d

Signed-off-by: Chris Leonard <chleonar@redhat.com>

update deep_gemm git tag again

2a29cc5

Signed-off-by: Chris Leonard <chleonar@redhat.com>

cleonard530 force-pushed the update_deep_gemm_tag_for_locality_domain_update branch from 3326236 to 2a29cc5 Compare October 14, 2026 03:11

cleonard530 changed the title ~~[Do Not Merge!] Update deep_gemm git tag for locality_domain update~~ Update deep_gemm git tag for locality_domain update Oct 14, 2026

njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 14, 2026

cleonard530 mentioned this pull request Oct 14, 2026

[Build] DeepGEMM migration to torch Stable ABI #59482

Merged

3 of 4 tasks

Remove deep_gemm shared library from ABI check

e72445e

Signed-off-by: Shengqi Chen <harry-chen@outlook.com>

Harry-Chen requested a review from khluu as a code owner October 14, 2026 04:00

Merge branch 'main' into update_deep_gemm_tag_for_locality_domain_update

1c8ba6b

Harry-Chen approved these changes Oct 14, 2026

View reviewed changes

Harry-Chen changed the title ~~Update deep_gemm git tag for locality_domain update~~ [Build] Update deep_gemm git tag for locality_domain update Oct 14, 2026

Harry-Chen enabled auto-merge (squash) October 14, 2026 05:28

ywang96 approved these changes Oct 14, 2026

View reviewed changes

ywang96 disabled auto-merge October 14, 2026 19:41

ywang96 merged commit ded7ae3 into vllm-project:main Oct 14, 2026
494 of 500 checks passed

pllopis mentioned this pull request Oct 14, 2026

[Bugfix] Preserve FP8 indexer WK pairs across load_weights calls #59223

Merged

3 of 4 tasks

WoosukKwon mentioned this pull request Oct 14, 2026

[Spec Decode] Remove Medusa and MLP speculator support #61701

Merged

6 tasks done

micah-wil mentioned this pull request Oct 14, 2026

Revert "[Build] Update deep_gemm git tag for locality_domain update" #61703

Merged

khluu mentioned this pull request Oct 14, 2026

Revert "[Build] Update deep_gemm git tag for locality_domain update (#61491)" #61704

Closed

Conversation

cleonard530 commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

mergify Bot commented Oct 13, 2026

Uh oh!

njhill commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

njhill commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cleonard530 commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

njhill commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

Harry-Chen commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

Harry-Chen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cleonard530 commented Oct 14, 2026

Uh oh!

khluu commented Oct 14, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cleonard530 commented Oct 13, 2026 •

edited

Loading