Skip to content

[Bugfix] Raise for unavailable piecewise CUDA graphs - #54782

Merged
Isotr0py merged 5 commits into
vllm-project:mainfrom
Isotr0py:fix-breakable-cg-silent-regress
Sep 2, 2026
Merged

[Bugfix] Raise for unavailable piecewise CUDA graphs#54782
Isotr0py merged 5 commits into
vllm-project:mainfrom
Isotr0py:fix-breakable-cg-silent-regress

Conversation

@Isotr0py

@Isotr0py Isotr0py commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Purpose

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@Isotr0py
fallback to eager
ed425d7 
Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@mergify mergify Bot added nvidia mrv2 Model Runner V2 specific bug Something isn't working labels Sep 1, 2026
@Isotr0py
clean
c958952 
Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@Isotr0py Isotr0py changed the title [Bugfix] Fallback to eager for unavailable piecewise CUDA graphs [Bugfix] Raise for unavailable piecewise CUDA graphs Sep 1, 2026
@Isotr0py
clean
d3f4fad 
Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@Isotr0py
Isotr0py marked this pull request as ready for review September 1, 2026 16:09
claude[bot]
claude Bot reviewed Sep 1, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@Isotr0py
Isotr0py requested a review from ZJY0516 September 1, 2026 16:09
ZJY0516
ZJY0516 reviewed Sep 1, 2026
View reviewed changes
Comment thread vllm/v1/worker/gpu/cudagraph_utils.py Outdated
@Isotr0py
address comment
a4bbaad 
Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Sep 1, 2026
@Isotr0py
Isotr0py enabled auto-merge (squash) September 1, 2026 17:34
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 1, 2026
@Isotr0py

Isotr0py commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #86664 for commit a4bbaad3b1f8.

@Isotr0py

Isotr0py commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

/ci retry

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Queued 2 failed job(s) for retry in Buildkite CI #86664.

@Isotr0py

Isotr0py commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

/ci retry

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #86787 for commit d0ab3a9e529a, running 2 failed step(s) from Buildkite CI #86664.

@Isotr0py

Isotr0py commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #86789 for commit d0ab3a9e529a.

@Isotr0py
Isotr0py merged commit 1c26e57 into vllm-project:main Sep 2, 2026
89 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Sep 2, 2026
@stefankoncarevic stefankoncarevic mentioned this pull request Sep 2, 2026
Merged
4 tasks
mylibrar pushed a commit to tanyuqian/vllm that referenced this pull request Sep 3, 2026
@Isotr0py suqisun
[Bugfix] Raise for unavailable piecewise CUDA graphs (vllm-project#54782
1f5dd0b 
)

Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@Isotr0py
Isotr0py deleted the fix-breakable-cg-silent-regress branch September 3, 2026 06:32
@AndreasKaratzas AndreasKaratzas mentioned this pull request Sep 3, 2026
Merged
This was referenced Sep 4, 2026
Merged
Merged
@avininjamay8 avininjamay8 mentioned this pull request Sep 8, 2026
Closed
sheralskumar pushed a commit to sheralskumar/vllm that referenced this pull request Sep 8, 2026
@Isotr0py @sheralskumar
[Bugfix] Raise for unavailable piecewise CUDA graphs (vllm-project#54782
c48c85b 
)

Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@avininjamay8 avininjamay8 mentioned this pull request Sep 9, 2026
Open
avininjamay8 pushed a commit to avininjamay8/vllm that referenced this pull request Sep 9, 2026
avininjamay8
[CI][ROCm][Disagg] Enable breakable CUDA graphs for MiniMax-M3 decode
f7b4310 
Nightly vLLM (vllm-project#54782) now requires breakable CUDA graphs or eager mode
for MiniMax sparse decode when piecewise graphs are enabled. Set
VLLM_USE_BREAKABLE_CUDAGRAPH=1 so decode bring-up passes on nightly.

Signed-off-by: avininjamay8 <avpaul@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@ZJY0516 ZJY0516 ZJY0516 approved these changes
@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner
@njhill njhill Awaiting requested review from njhill njhill is a code owner
@yewentao256 yewentao256 Awaiting requested review from yewentao256 yewentao256 is a code owner

Assignees

No one assigned

Labels

bug Something isn't working mrv2 Model Runner V2 specific nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

NVIDIA
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Isotr0py @ZJY0516