[Bugfix][CI] Set cudagraph_mode=FULL for the Ernie4.5-VL ViT cudagraph test - #54957
Merged
AndreasKaratzas merged 2 commits intoSep 2, 2026
Merged
Conversation
…h test Ernie4_5_VLMoeModel keeps @support_torch_compile commented out, because its split of text and vision experts breaks compilation, so piecewise cudagraphs have nothing to partition. The test asked for the default FULL_AND_PIECEWISE, which silently captured nothing until the guard added in vllm-project#54782 started raising for it. Pin the mode to FULL, as the deepseek_ocr entry in the same file already does. Only the encoder graphs this test covers are captured. Signed-off-by: Stefan Koncarevic <stefan.koncarevic@amd.com>
stefankoncarevic
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
September 2, 2026 12:34
Member
|
/ci run |
|
✅ Triggered Buildkite CI #86900 for commit |
AndreasKaratzas
approved these changes
Sep 2, 2026
mylibrar
pushed a commit
to tanyuqian/vllm
that referenced
this pull request
Sep 3, 2026
…h test (vllm-project#54957) Signed-off-by: Stefan Koncarevic <stefan.koncarevic@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ernie4.5-VL ViT cudagraph test fails after #54782
Failing test:
test_vit_cudagraph_image[ernie45_vl]AMD CI: https://buildkite.com/vllm/amd-ci/builds/12553/list?sid=01a0615a-019d-4492-a92c-a4018dfdcc8b&tab=output
The same group failed on both MI300 and MI355.
Error
Raised in
vllm/v1/worker/gpu/cudagraph_utils.py, during engine start.What exposed it
1c26e57d3c— [Bugfix] Raise for unavailable piecewise CUDA graphs (#54782).It added a guard that raises when piecewise cudagraphs are requested for a
model with no active
@support_torch_compilewrapper.Root cause
The guard is correct; the misconfiguration predates it.
Ernie4_5_VLMoeModelkeeps its
@support_torch_compiledecorator commented out, since the modelwas added in #22514:
So the model is not compiled, piecewise cudagraphs have nothing to partition,
and the test asks for the default
FULL_AND_PIECEWISE. Until #54782 thissilently captured nothing.
Not platform-specific:
VLLM_USE_BREAKABLE_CUDAGRAPHdefaults toFalseeverywhere and the test is gated on
is_cuda_alike(), so CUDA should hit ittoo.
Ernie is the only affected model in that file —
glm4_1vandstep3_vlpass,and
deepseek_ocralready pinscudagraph_mode.Fix
Pin the mode for the Ernie entry, the way
deepseek_ocrin the same filealready does:
Verified on MI300X: fails in 31s before, passes in 40s after.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.