[CI][ROCm][Disagg] Enable breakable CUDA graphs for MiniMax-M3-MXFP8 decode - #55829
Closed
avininjamay8 wants to merge 1 commit into
Closed
avininjamay8 wants to merge 1 commit into
avininjamay8 wants to merge 1 commit into
Conversation
Nightly vLLM (vllm-project#54782) now requires breakable CUDA graphs or eager mode for MiniMax sparse decode when piecewise graphs are enabled. Set VLLM_USE_BREAKABLE_CUDAGRAPH=1 so decode bring-up passes on nightly. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@lcskrishna were you mentioning abt this issue in Thursday's evening meeting , will close this incase you addressed already. |
Contributor
Author
|
Closing stuck draft PR; reopening as ready-for-review (non-draft). |
Contributor
Author
|
Closing stuck draft; replacing with ready-for-review PR from fix/mm3-breakable-cudagraph-open. |
Contributor
Author
|
Superseded by #56075 (non-draft replacement). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #54782. After that merge, MiniMax-M3-MXFP8 decode fails in our ROCm disagg CI:
Prefill runs eager; decode uses piecewise graphs. Set
VLLM_USE_BREAKABLE_CUDAGRAPH: "1"inmodels.yamlso bring-up and GSM8K pass on nightly.Changes
.buildkite/amd-disagg/models.yamlonly:MiniMax-M3-MXFP8env:VLLM_USE_BREAKABLE_CUDAGRAPH: "0"→"1"No launcher, MoRIIO, or harness script changes.
Test Plan
MoRIIO 1P1D TP8 disaggregated serving,
ROUTER_TYPE=proxy,RUN_AFTER_HEALTH=accuracy, imagevllm/vllm-openai-rocm:nightly.MiniMax-M3-MXFP8 — 1P1D TP8
GSM8K evaluation
lm_eval --model local-completions \ --tasks gsm8k \ --model_args "model=/data/models2/MiniMax-M3-MXFP8,base_url=http://127.0.0.1:10001/v1/completions,num_concurrent=64,max_retries=3,tokenized_requests=False,trust_remote_code=True,timeout=7200" \ --limit 250Test Result
MiniMax-M3-MXFP8, MoRIIO 1P1D TP8 (proxy). GSM8K flexible-extract, threshold 0.90.
models.yaml(VLLM_USE_BREAKABLE_CUDAGRAPH=0)piecewise CUDA graphs unavailable)