Conversation
Assisted-by: OpenAI Codex Signed-off-by: tangzzycc <3081129260@qq.com>
tangzzycc
requested review from
AndreasKaratzas,
WoosukKwon,
mgoin,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
August 17, 2026 17:25
mgehre-amd
reviewed
Sep 2, 2026
| ) | ||
| w_zp = zp_unpacked.to(c.act_type).contiguous() | ||
| self._transform_param(layer, self.w_zp_name, lambda x: w_zp) | ||
| elif self.w_zp_name is not None: |
Contributor
There was a problem hiding this comment.
Can this be removed in the GPTQ loader instead of the RDNAHybridW4A16 kernel? I guess the same mismatch between c.zero_points and self.w_zp_name might also confuse other kernels.
This was referenced Sep 2, 2026
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Symmetric GPTQ
uint4b8uses a fixed zero point of 8, but some checkpoints still contain redundant packedqzeros.RDNAHybridW4A16LinearKernelpreviously passed this tensor to the kernel, causing startup failures such as:This PR drops redundant
qzerosafter loading symmetric GPTQ weights and adds regression coverage. The existing asymmetric zero-point path is unchanged.Duplicate-work check
Open PR searches for
RDNAHybridW4A16LinearKernel qzerosandsymmetric qzeros ROCm W4A16found no duplicate. PRs #47770 and #48998 only addressTritonW4A16LinearKernel; neither changes the RDNA hybrid kernel.Test Plan
I ran the focused and complete hybrid W4A16 tests, applicable pre-commit hooks, and an end-to-end before/after serving test with the official
Qwen/Qwen3.5-27B-GPTQ-Int4checkpoint.Test commands
VLLM_ROCM_USE_AITER=0 VLLM_ENABLE_V1_MULTIPROCESSING=0 \ .venv/bin/vllm serve ~/models/Qwen3.5-27B-GPTQ-Int4 \ --language-model-only --attention-backend ROCM_ATTN \ --max-model-len 2048 --max-num-seqs 1 \ --gpu-memory-utilization 0.3 --enforce-eager --port 8001Test Result
qzerosshape mismatch abovegit diff --check: passedAI assistance
OpenAI Codex assisted with this change. I reviewed and understand every submitted line and ran the validation reported above.
No documentation update is required because this change does not alter any user-facing API or configuration.
Essential Elements of an Effective PR Description Checklist