Skip to content

[ROCm][Bugfix] Fix Triton W4A16 bug in determining if transpose is required for GPTQ/AutoGPTQ - #48998

Merged
tjtanaa merged 6 commits into
vllm-project:mainfrom
qli88:qiang_asym_quant_fix
Aug 17, 2026
Merged

tjtanaa merged 6 commits into
vllm-project:mainfrom
qli88:qiang_asym_quant_fix

Conversation

@qli88

@qli88 qli88 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Purpose

this commit #47770 (for issue #47159) introduced a shape-based method to determine if qzeros need transposing, but the shape check is ambiguous when the two candidate shapes are identical. (cyankiwi-MiniMax-M3-AWQ-INT4 with tp=8 as an example). This PR is to fix this issue:

  1. Use metadata instead of shape-based method;
  2. in case output_dim is not set, fall back to shape-based method;
  3. if 2 candidate shapes are identical, set transpose = True as default.

Test Plan

  1. raydelossantos/Qwen3.6-27B-GPTQ-Int4:
    vllm serve /data/raydelossantos-Qwen3.6-27B-GPTQ-Int4/
    --attention-backend TRITON_ATTN
    --max-model-len 65536
    --reasoning-parser qwen3
    --enable-auto-tool-choice \
    --tool-call-parser qwen3_coder

  2. cyankiwi/MiniMax-M3-AWQ-INT4:
    VLLM_USE_BREAKABLE_CUDAGRAPH=0 vllm serve /data/cyankiwi-MiniMax-M3-AWQ-INT4/
    --block-size 128
    --tensor-parallel-size 8
    --attention-backend TRITON_ATTN
    --tool-call-parser minimax_m3
    --enable-auto-tool-choice
    --reasoning-parser minimax_m3
    --moe-backend emulation

Both work as expected.

qli88 added 2 commits July 17, 2026 18:32
… layout (vllm-project#47770)"

This commit breaks asymm quantized models like cyankiwi-MiniMax-M3-AWQ-INT4.

Signed-off-by: Qiang Li <qiang.li2@amd.com>
…quired for GPTQ/AutoGPTQ

Signed-off-by: Qiang Li <qiang.li2@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@BowenBao BowenBao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM, minor comment.

cc @tjtanaa, @AndreasKaratzas

Comment thread vllm/model_executor/kernels/linear/mixed_precision/triton_w4a16.py
@AndreasKaratzas AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 22, 2026
@AndreasKaratzas

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83777 for commit b6a08da89d4c.

@tjtanaa

tjtanaa commented Aug 17, 2026

Copy link
Copy Markdown
Member

/ci run

@tjtanaa
tjtanaa enabled auto-merge (squash) August 17, 2026 11:01
@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #84195 for commit b94587e7147b.

@tjtanaa
tjtanaa merged commit 1d3a8b9 into vllm-project:main Aug 17, 2026
86 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Aug 17, 2026
zyp2014 pushed a commit to zyp2014/vllm that referenced this pull request Aug 21, 2026
…quired for GPTQ/AutoGPTQ (vllm-project#48998)

Signed-off-by: Qiang Li <qiang.li2@amd.com>
wyettzeng pushed a commit to wyettzeng/vllm that referenced this pull request Aug 21, 2026
…quired for GPTQ/AutoGPTQ (vllm-project#48998)

Signed-off-by: Qiang Li <qiang.li2@amd.com>
Signed-off-by: Wyett <wyettzeng@gmail.com>
zufangzhu pushed a commit to zufangzhu/vllm that referenced this pull request Aug 24, 2026
…quired for GPTQ/AutoGPTQ (vllm-project#48998)

Signed-off-by: Qiang Li <qiang.li2@amd.com>
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
khushali9 pushed a commit to khushali9/vllm that referenced this pull request Aug 29, 2026
…quired for GPTQ/AutoGPTQ (vllm-project#48998)

Signed-off-by: Qiang Li <qiang.li2@amd.com>
Signed-off-by: khushali9 <khushali.desai9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants