[Refactor] Remove dead code from parser infrastructure#44279
Merged
Conversation
Signed-off-by: sfeng33 <4florafeng@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfeng33
requested review from
aarnphm,
bbrowning and
chaunceyjiang
as code owners
yewentao256
approved these changes
Jun 2, 2026
yewentao256
left a comment
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
This was referenced Jun 2, 2026
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…44279) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
bnellnm
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jun 4, 2026
…44279) Signed-off-by: sfeng33 <4florafeng@gmail.com>
andakai
pushed a commit
to andakai/vllm
that referenced
this pull request
Jun 4, 2026
…44279) Signed-off-by: sfeng33 <4florafeng@gmail.com>
JisoLya
pushed a commit
to JisoLya/vllm
that referenced
this pull request
Jun 5, 2026
…44279) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: JisoLya <523420504@qq.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
…44279) Signed-off-by: sfeng33 <4florafeng@gmail.com>
alexbi29
added a commit
to alexbi29/vllm
that referenced
this pull request
Jun 8, 2026
… API Three adaptations required after upstream refactors: 1. _WrappedParser removed (vllm-project#44279): replaced with an inline subclass _Gemma4Parser(DelegatingParser) with reasoning_parser_cls and tool_parser_cls set as class attributes directly. 2. parse_delta() gained a required `finished` kwarg (vllm-project#44017): updated _run_streaming to pass finished=(last token), _run_single_delta to pass finished=True, and the multi-turn loop to pass finished=False. 3. tool_choice="none" short-circuit added (vllm-project#42752): parse_delta now returns raw content immediately when request.tool_choice is "none", which is the default when no tools are specified. Fixed _make_request to include a dummy tool so tool_choice stays "auto" and the parser exercises its actual tool-extraction logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
…44279) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
alexbi29
added a commit
to alexbi29/vllm
that referenced
this pull request
Jun 12, 2026
… API Three adaptations required after upstream refactors: 1. _WrappedParser removed (vllm-project#44279): replaced with an inline subclass _Gemma4Parser(DelegatingParser) with reasoning_parser_cls and tool_parser_cls set as class attributes directly. 2. parse_delta() gained a required `finished` kwarg (vllm-project#44017): updated _run_streaming to pass finished=(last token), _run_single_delta to pass finished=True, and the multi-turn loop to pass finished=False. 3. tool_choice="none" short-circuit added (vllm-project#42752): parse_delta now returns raw content immediately when request.tool_choice is "none", which is the default when no tools are specified. Fixed _make_request to include a dummy tool so tool_choice stays "auto" and the parser exercises its actual tool-extraction logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alexbi29
added a commit
to alexbi29/vllm
that referenced
this pull request
Jun 12, 2026
… API Three adaptations required after upstream refactors: 1. _WrappedParser removed (vllm-project#44279): replaced with an inline subclass _Gemma4Parser(DelegatingParser) with reasoning_parser_cls and tool_parser_cls set as class attributes directly. 2. parse_delta() gained a required `finished` kwarg (vllm-project#44017): updated _run_streaming to pass finished=(last token), _run_single_delta to pass finished=True, and the multi-turn loop to pass finished=False. 3. tool_choice="none" short-circuit added (vllm-project#42752): parse_delta now returns raw content immediately when request.tool_choice is "none", which is the default when no tools are specified. Fixed _make_request to include a dummy tool so tool_choice stays "auto" and the parser exercises its actual tool-extraction logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> (cherry picked from commit c37293e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
_WrappedParser— move sub-parser instantiation intoParser.__init__MiniMaxM2Parser— just composed two already-registered parsersParserManagerregistry machinery (register_module,register_lazy_module,get_parser_internal,list_registered,import_parser, lazy-registration table)Test Plan