[CI] Add missing vllm/parser/ CI trigger and fix test_parse.py #44352
Merged
Conversation
MatthewBonanni
added
the
ready
Collaborator
|
The docs build failed |
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…project#44352) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
andakai
pushed a commit
to andakai/vllm
that referenced
this pull request
Jun 4, 2026
…project#44352) Signed-off-by: sfeng33 <4florafeng@gmail.com>
JisoLya
pushed a commit
to JisoLya/vllm
that referenced
this pull request
Jun 5, 2026
…project#44352) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: JisoLya <523420504@qq.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
…project#44352) Signed-off-by: sfeng33 <4florafeng@gmail.com>
waqahmed-amd-fi
pushed a commit
to waqahmed-amd-fi/vllm
that referenced
this pull request
Jun 10, 2026
…project#44352) Signed-off-by: sfeng33 <4florafeng@gmail.com> Signed-off-by: Waqar Ahmed <waqar.ahmed@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#44279 removed
_WrappedParserfromvllm/parser/abstract_parser.pyand updatedtest_streaming.pyto useDelegatingParser, buttest_parse.pywas added by a separate PR around the same time and still referenced_WrappedParser. The CI didn't catch this becausevllm/parser/wasn't listed as a trigger path for the job — onlytests/parserwas. So the job only ran when test files changed, not when the source code they test changed.In this PR, fix the failing test and CI trigger.
Test Plan