[Bugfix] Fix broken test_parse.py after _WrappedParser removal#44351
Closed
sfeng33 wants to merge 1 commit into
Closed
[Bugfix] Fix broken test_parse.py after _WrappedParser removal#44351sfeng33 wants to merge 1 commit into
sfeng33 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_parse.pystill imported_WrappedParser, which was removed in [Refactor] Remove dead code from parser infrastructure #44279. Updated to useDelegatingParserwith a local subclass, matching the pattern already applied intest_streaming.py.vllm/parser/tosource_file_dependenciesin theasync-engine-inputs-utils-worker-config-cpuCI job. This was missing, so changes tovllm/parser/source code didn't trigger the job that runspytest -v -s parser, which is how [Refactor] Remove dead code from parser infrastructure #44279 merged without catching the breakage.Test plan
pytest tests/parser/test_parse.py -v— all 14 tests pass