Skip to content

[DOC] Update Gemma 4#39661

Closed
jeejeelee wants to merge 2 commits intomainfrom
gemma-doc
Closed

[DOC] Update Gemma 4#39661
jeejeelee wants to merge 2 commits intomainfrom
gemma-doc

Conversation

@jeejeelee
Copy link
Copy Markdown
Collaborator

@jeejeelee jeejeelee commented Apr 13, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee requested a review from DarkLight1337 April 13, 2026 03:21
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 13, 2026

Documentation preview: https://vllm--39661.org.readthedocs.build/en/39661/

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Gemma 4 to the supported models documentation. The review feedback identifies a formatting error where a leading pipe was omitted, suggests using the text-only architecture name for this specific table, and recommends correctly indicating LoRA support.

| `Gemma2ForCausalLM` | Gemma 2 | `google/gemma-2-9b`, `google/gemma-2-27b`, etc. | ✅︎ | ✅︎ |
| `Gemma3ForCausalLM` | Gemma 3 | `google/gemma-3-1b-it`, etc. | ✅︎ | ✅︎ |
| `Gemma3nForCausalLM` | Gemma 3n | `google/gemma-3n-E2B-it`, `google/gemma-3n-E4B-it`, etc. | | |
`Gemma4ForConditionalGeneration` | Gemma 4 | `google/gemma-4-31B`, `google/gemma-4-26B-A4B-it`, etc. | | ✅︎ |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The entry for Gemma 4 has several issues that should be addressed:

  1. Formatting: The line is missing the leading pipe (|), which breaks the markdown table rendering.
  2. Architecture Name: This table is for text-only generative models. The correct architecture name for the text-only version is Gemma4ForCausalLM. Gemma4ForConditionalGeneration is the multimodal variant and should be listed in the Multimodal Language Models section instead.
  3. LoRA Support: The implementation in vllm/model_executor/models/gemma4.py indicates that LoRA is supported (it inherits from SupportsLoRA). The LoRA column should be marked with ✅︎ to reflect this capability.
Suggested change
`Gemma4ForConditionalGeneration` | Gemma 4 | `google/gemma-4-31B`, `google/gemma-4-26B-A4B-it`, etc. | | ✅︎ |
| `Gemma4ForCausalLM` | Gemma 4 | `google/gemma-4-31B`, `google/gemma-4-26B-A4B-it`, etc. | ✅︎ | ✅︎ |

@DarkLight1337
Copy link
Copy Markdown
Member

There is already a PR #39607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants