Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/models/supported_models.md
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@
| `Gemma2ForCausalLM` | Gemma 2 | `google/gemma-2-9b`, `google/gemma-2-27b`, etc. | ✅︎ | ✅︎ |
| `Gemma3ForCausalLM` | Gemma 3 | `google/gemma-3-1b-it`, etc. | ✅︎ | ✅︎ |
| `Gemma3nForCausalLM` | Gemma 3n | `google/gemma-3n-E2B-it`, `google/gemma-3n-E4B-it`, etc. | | |
`Gemma4ForConditionalGeneration` | Gemma 4 | `google/gemma-4-31B`, `google/gemma-4-26B-A4B-it`, etc. | | ✅︎ |

Check failure on line 403 in docs/models/supported_models.md

View workflow job for this annotation

GitHub Actions / pre-commit

MD055/table-pipe-style Table pipe style [Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The entry for Gemma 4 has several issues that should be addressed:

  1. Formatting: The line is missing the leading pipe (|), which breaks the markdown table rendering.
  2. Architecture Name: This table is for text-only generative models. The correct architecture name for the text-only version is Gemma4ForCausalLM. Gemma4ForConditionalGeneration is the multimodal variant and should be listed in the Multimodal Language Models section instead.
  3. LoRA Support: The implementation in vllm/model_executor/models/gemma4.py indicates that LoRA is supported (it inherits from SupportsLoRA). The LoRA column should be marked with ✅︎ to reflect this capability.
Suggested change
`Gemma4ForConditionalGeneration` | Gemma 4 | `google/gemma-4-31B`, `google/gemma-4-26B-A4B-it`, etc. | | ✅︎ |
| `Gemma4ForCausalLM` | Gemma 4 | `google/gemma-4-31B`, `google/gemma-4-26B-A4B-it`, etc. | ✅︎ | ✅︎ |

| `GlmForCausalLM` | GLM-4 | `zai-org/glm-4-9b-chat-hf`, etc. | ✅︎ | ✅︎ |
| `Glm4ForCausalLM` | GLM-4-0414 | `zai-org/GLM-4-32B-0414`, etc. | ✅︎ | ✅︎ |
| `Glm4MoeForCausalLM` | GLM-4.5, GLM-4.6, GLM-4.7 | `zai-org/GLM-4.5`, etc. | ✅︎ | ✅︎ |
Expand Down
Loading