[Doc] Add Gemma 4 to supported models list#39607
Merged
DarkLight1337 merged 6 commits intovllm-project:mainfrom Apr 17, 2026
Merged
[Doc] Add Gemma 4 to supported models list#39607DarkLight1337 merged 6 commits intovllm-project:mainfrom
DarkLight1337 merged 6 commits intovllm-project:mainfrom
Conversation
Signed-off-by: z1ying <tzzying@outlook.com>
Contributor
|
Documentation preview: https://vllm--39607.org.readthedocs.build/en/39607/ |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in docs/models/supported_models.md to include support for Gemma 4 models, specifically adding Gemma4ForCausalLM and Gemma4ForConditionalGeneration to their respective tables. I have no feedback to provide.
Address review feedback: remove video from native modalities, mark audio as variant-specific since only E2B/E4B include an audio tower, and add a note explaining these constraints. Signed-off-by: z1ying <tzzying@outlook.com>
5cc6d7f to
1820810
Compare
…dels Signed-off-by: Ziying Tao <tzzying@outlook.com>
4740c8f to
d1b369e
Compare
Contributor
Author
|
Updated. Please let me know if this looks good now. @lucianommartins @ywang96 |
Contributor
Author
|
Thanks for the review! @ywang96 Could you help merge this PR? |
askliar
pushed a commit
to askliar/vllm
that referenced
this pull request
Apr 17, 2026
Signed-off-by: z1ying <tzzying@outlook.com> Signed-off-by: Ziying Tao <tzzying@outlook.com>
lisp19
pushed a commit
to lisp19/vllm
that referenced
this pull request
Apr 20, 2026
Signed-off-by: z1ying <tzzying@outlook.com> Signed-off-by: Ziying Tao <tzzying@outlook.com>
bnellnm
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Apr 20, 2026
Signed-off-by: z1ying <tzzying@outlook.com> Signed-off-by: Ziying Tao <tzzying@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Gemma4ForCausalLMandGemma4ForConditionalGenerationare already implemented and registered in vLLM (gemma4.py,gemma4_mm.py), but were missing from thesupported_models.mddocumentation table. This PR adds the two missing entries.Changes
Documentation only —
docs/models/supported_models.md:Gemma4ForCausalLM— LoRA ✅, PP ✅, example modelgoogle/gemma-4-E2B-it.Gemma4ForConditionalGenerationwith modalitiesT + I⁺ + V + A*, PP ✅, no LoRA, example modelsgoogle/gemma-4-E2B-it,google/gemma-4-E4B-it.*as a generic marker meaning "Only specific variants of the model support this modality", reusable for future models with variant-specific modalities.gemma-4-E2Bandgemma-4-E4Bvariants, and (b) the model does not ingest videos directly, but vLLM's Gemma 4 implementation supports video inputs by handling video processing internally — users can send videos directly in the message structure.Both Gemma 4 rows follow the same format as the existing Gemma 3 entries directly above them.
How the fields were verified
gemma4.pyandgemma4_mm.py.tests/models/registry.py.Notes
The additional
*legend is intentionally generic rather than Gemma-specific so it can be reused by future models that have modality support varying across checkpoints within a single architecture.Test
No source code was changed. Existing Gemma 4 tests are unaffected.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.