[Quantization][Deprecation] Remove PTPC FP8#32700
[Quantization][Deprecation] Remove PTPC FP8#32700robertgshaw2-redhat wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Robert Shaw <robshaw@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request successfully removes the PTPC FP8 quantization method from the codebase. The changes are consistent across all modified files, including the removal of the test file, updates to the quantization registry, and removal from the ROCm platform's supported quantization list. The deprecation notice for PTPC FP8 was previously released in 0.14, making this removal a logical next step. No issues were found.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
| commands="${commands} \ | ||
| --ignore=kernels/moe/test_moe.py \ | ||
| --ignore=kernels/moe/test_cutlass_moe.py \ | ||
| --ignore=kernels/moe/test_triton_moe_ptpc_fp8.py" |
There was a problem hiding this comment.
Missing closing quote breaks shell script syntax
High Severity
Removing the --ignore=kernels/moe/test_triton_moe_ptpc_fp8.py" line also removed the closing quote for the string literal. Line 134 now ends with a backslash \ (line continuation) without a closing quote, causing fi on line 135 to become part of the string instead of terminating the if block. This will cause a bash syntax error and break the AMD hardware CI pipeline.
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
|
This pull request has merge conflicts that must be resolved before it can be |
|
@robertgshaw2-redhat does the current |
|
Hi @robertgshaw2-redhat :) Can we rebase this PR so that we merge it? |
Purpose
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.