Skip to content

[Quantization][Deprecation] Remove PTPC FP8#32700

Open
robertgshaw2-redhat wants to merge 1 commit intomainfrom
remove-ptpc-fp8
Open

[Quantization][Deprecation] Remove PTPC FP8#32700
robertgshaw2-redhat wants to merge 1 commit intomainfrom
remove-ptpc-fp8

Conversation

@robertgshaw2-redhat
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Jan 20, 2026

Purpose

  • now that 0.14 is out with deprecation notice, remove completely from 0.15

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Robert Shaw <robshaw@redhat.com>
@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 20, 2026
@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Jan 20, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the PTPC FP8 quantization method from the codebase. The changes are consistent across all modified files, including the removal of the test file, updates to the quantization registry, and removal from the ROCm platform's supported quantization list. The deprecation notice for PTPC FP8 was previously released in 0.14, making this removal a logical next step. No issues were found.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

commands="${commands} \
--ignore=kernels/moe/test_moe.py \
--ignore=kernels/moe/test_cutlass_moe.py \
--ignore=kernels/moe/test_triton_moe_ptpc_fp8.py"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing quote breaks shell script syntax

High Severity

Removing the --ignore=kernels/moe/test_triton_moe_ptpc_fp8.py" line also removed the closing quote for the string literal. Line 134 now ends with a backslash \ (line continuation) without a closing quote, causing fi on line 135 to become part of the string instead of terminating the if block. This will cause a bash syntax error and break the AMD hardware CI pipeline.

Fix in Cursor Fix in Web

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@mergify
Copy link

mergify bot commented Jan 21, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @robertgshaw2-redhat.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 21, 2026
@tjtanaa
Copy link
Collaborator

tjtanaa commented Jan 21, 2026

@robertgshaw2-redhat does the current fp8 quantization works on ROCm as well? Is the NVIDIA's fp8 is PTPC quantization?

@AndreasKaratzas
Copy link
Collaborator

Hi @robertgshaw2-redhat :) Can we rebase this PR so that we merge it?

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work! Please merge from main to fix the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants