Skip to content

[ROCm][CI] Stabilize ROCm speech-to-text translation test with lower min acc threshold #37723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 2 commits into from
Mar 22, 2026
Merged

[ROCm][CI] Stabilize ROCm speech-to-text translation test with lower min acc threshold #37723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92007eb
[ROCm][CI] Stabilize ROCm speech-to-text translation test with ROCM_E…
AndreasKaratzas Mar 20, 2026
b7525f3
[CI] Lowering acc threshold
AndreasKaratzas Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/entrypoints/openai/speech_to_text/test_translation_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ async def test_streaming_response(foscolo, client_and_model, server):
# being very close semantically.
assert (
sum([x == y for x, y in zip(res_stream, res_no_stream.text.split())])
>= len(res_stream) * 0.9
>= len(res_stream) * 0.87
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is misleading, please update it to reflect what you've actually changed

Copy link
Copy Markdown
Collaborator Author

@AndreasKaratzas AndreasKaratzas Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarkLight1337 True, sorry, I forgot to do that, initially I thought of adding the rocm args, but then I saw the comment and thought that this flakiness is expected. Btw, I'll probably refactor this test, but I though of first stabilize the CI.

)


Expand Down
Loading