[Bugfix] Fix mm budget setting for Qwen Omni models#33634
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Feb 3, 2026
Merged
[Bugfix] Fix mm budget setting for Qwen Omni models#33634DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
ywang96
requested review from
DarkLight1337,
NickLucche and
tjtanaa
as code owners
mergify
bot
added
multi-modality
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a potential KeyError during multi-modal budget calculation for models that share placeholders between modalities, such as Qwen Omni. The change filters out active modalities without independent placeholder tokens, which is a simple and effective solution to prevent a crash. The implementation is sound and I have no further recommendations.
5 tasks
This was referenced Feb 3, 2026
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: Pai <416932041@qq.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: Pai <416932041@qq.com>
linyueqian
added a commit
to linyueqian/vllm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: linyueqian <linyueqian@outlook.com>
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Roger Wang <hey@rogerw.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
If a model has hybrid-modality setting (e.g.,
use_audio_in_video=Truefor Qwen Omni model series) then multiple modalities can share the same placeholder inMultiModalInputs. This PR makes the modality checking more robust while add a comment to indicate so.Fixes #33630
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.