Skip to content

[Bugfix] fix qwen3-asr response error#33644

Merged
vllm-bot merged 4 commits intovllm-project:mainfrom
jesse996:main
Feb 3, 2026
Merged

[Bugfix] fix qwen3-asr response error#33644
vllm-bot merged 4 commits intovllm-project:mainfrom
jesse996:main

Conversation

@jesse996
Copy link
Copy Markdown
Contributor

@jesse996 jesse996 commented Feb 3, 2026

Purpose

fix #33643

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: jesse <szxfml@gmail.com>
@jesse996 jesse996 requested a review from sighingnow as a code owner February 3, 2026 04:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added qwen Related to Qwen models bug Something isn't working labels Feb 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a response error in the Qwen3-ASR model by improving the handling of audio embeddings. The core change involves refactoring the creation of Qwen3ASRMultiModalDataParser to include expected_hidden_size during initialization. This is achieved by adding a get_data_parser method to Qwen3ASRProcessingInfo and updating Qwen3ASRMultiModalProcessor to use it. This change enables validation of audio embedding dimensions, preventing potential errors from mismatched shapes and improving the model's robustness. The refactoring also centralizes the parser creation logic, which is a good practice. The changes are correct and well-implemented.

Signed-off-by: jesse <szxfml@gmail.com>
@jesse996 jesse996 requested a review from Isotr0py February 3, 2026 06:49
@Isotr0py Isotr0py enabled auto-merge (squash) February 3, 2026 07:08
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 3, 2026
Signed-off-by: jesse <szxfml@gmail.com>
auto-merge was automatically disabled February 3, 2026 09:22

Head branch was pushed to by a user without write access

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Feb 3, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>

Signed-off-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
@vllm-bot vllm-bot merged commit ceab70c into vllm-project:main Feb 3, 2026
5 of 7 checks passed
Hivenet-Igor pushed a commit to Hivenet-Igor/vllm that referenced this pull request Feb 3, 2026
Signed-off-by: jesse <szxfml@gmail.com>
Signed-off-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Igor Carrara <igor.carrara@hivenet.com>
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: jesse <szxfml@gmail.com>
Signed-off-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Pai <416932041@qq.com>
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: jesse <szxfml@gmail.com>
Signed-off-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Pai <416932041@qq.com>
gameofdimension pushed a commit to gameofdimension/vllm that referenced this pull request Feb 5, 2026
Signed-off-by: jesse <szxfml@gmail.com>
Signed-off-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: jesse <szxfml@gmail.com>
Signed-off-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: serve qwen3-asr-1.7b error

4 participants