[CI/Bug]Fix multimodal encoder budget KeyError for shared audio placeholders#33676
Closed
pacoxu wants to merge 1 commit intovllm-project:mainfrom
Closed
[CI/Bug]Fix multimodal encoder budget KeyError for shared audio placeholders#33676pacoxu wants to merge 1 commit intovllm-project:mainfrom
pacoxu wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a KeyError that occurred during the multimodal encoder budget calculation. The fix correctly replaces a direct dictionary access with a safer .get() call, using an assignment expression to avoid a second lookup. This change not only resolves the KeyError but also improves robustness by filtering out None values, which could lead to a TypeError in downstream processing. The change is concise, correct, and improves the overall reliability of the code.
Member
|
It has been fixed by #33634 already. |
Contributor
Author
thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix a keyerror in CI https://buildkite.com/vllm/ci/builds/49647/steps/canvas?jid=019c205f-dc84-45ec-949c-ea4fc62d9a54
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.