[BUG] relax pirate persona assertion in test_system_prompt_override#33390
Open
pacoxu wants to merge 1 commit intovllm-project:mainfrom
Open
[BUG] relax pirate persona assertion in test_system_prompt_override#33390pacoxu wants to merge 1 commit intovllm-project:mainfrom
pacoxu wants to merge 1 commit intovllm-project:mainfrom
Conversation
…ride Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test by relaxing a strict assertion. The test now correctly validates that either the model's output reflects the requested persona or the reasoning behind the output acknowledges it. This is a more robust approach for testing language models, which can be non-deterministic. The implementation is clean, and the improved assertion message will aid in debugging future test failures. The change is sound and I have no concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A test fix for #32918.
See #32918 (comment)
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.