Skip to content

[BUG] relax pirate persona assertion in test_system_prompt_override #33390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pacoxu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG] relax pirate persona assertion in test_system_prompt_override #33390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions tests/entrypoints/openai/responses/test_harmony.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,27 +1259,28 @@ async def test_system_prompt_override(client: OpenAI, model_name: str):
assert response.status == "completed"
assert response.output_text is not None

# Verify the response reflects the pirate personality
output_text = response.output_text.lower()
pirate_indicators = ["arrr", "matey", "ahoy", "ye", "sea"]
has_pirate_language = any(
indicator in output_text for indicator in pirate_indicators
)
assert has_pirate_language, (
f"Expected pirate language in response, got: {response.output_text}"
)

# Verify the reasoning mentions the custom system prompt
# Extract reasoning first (needed for relaxed persona check)
reasoning_item = None
for item in response.output:
if item.type == "reasoning":
reasoning_item = item
break

assert reasoning_item is not None, "Expected reasoning item in output"
reasoning_text = reasoning_item.content[0].text.lower()
assert "pirate" in reasoning_text, (
f"Expected reasoning to mention pirate, got: {reasoning_text}"

# Verify the custom system prompt was applied: either response uses pirate
# language, or reasoning mentions the pirate persona. Models may occasionally
# produce generic replies despite considering the persona.
output_text = response.output_text.lower()
pirate_indicators = ["arrr", "matey", "ahoy", "ye", "sea", "aye"]
has_pirate_language = any(
indicator in output_text for indicator in pirate_indicators
)
reasoning_mentions_pirate = "pirate" in reasoning_text
assert has_pirate_language or reasoning_mentions_pirate, (
f"Expected pirate language in response or 'pirate' in reasoning. "
f"Response: {response.output_text!r}. Reasoning excerpt: "
f"{reasoning_text[:200]!r}..."
)

# Test 2: Verify system message is not duplicated in input_messages
Expand Down