[Fix] Update CUTLASS_REVISION to v4.3.5#32918
[Fix] Update CUTLASS_REVISION to v4.3.5#32918pacoxu wants to merge 5 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the CUTLASS dependency from v4.2.1 to v4.3.5 to incorporate support for Blackwell architectures. The modification in CMakeLists.txt is straightforward and correct. However, given that this is a significant dependency update, it has the potential to impact various parts of the system, including kernel generation scripts and other components that rely on CUTLASS. The pull request description currently lacks a test plan and corresponding results. For a change of this nature, it is critical to provide detailed information about the testing performed to validate that the new version does not introduce any regressions and that the intended new functionalities work as expected. Please update the pull request to include a comprehensive test plan and its outcomes.
|
Let's see if this breaks anything |
CI failed for I rebased with latest main branch. After re-run, this is passed. |
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has merge conflicts that must be resolved before it can be |
Purpose
https://github.com/NVIDIA/cutlass?tab=readme-ov-file#whats-new-in-cutlass-43
https://docs.nvidia.com/cutlass/latest/CHANGELOG.html
cutlass 4.3.5 vs 4.2.1, it includes many Blackwell SM100/SM103/SM120/SM130 support feature/bugfix.
Probably this may benefit PRs like
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.