Skip to content

[Fix] Update CUTLASS_REVISION to v4.3.5#32918

Closed
pacoxu wants to merge 5 commits intovllm-project:mainfrom
pacoxu:main
Closed

[Fix] Update CUTLASS_REVISION to v4.3.5#32918
pacoxu wants to merge 5 commits intovllm-project:mainfrom
pacoxu:main

Conversation

@pacoxu
Copy link
Copy Markdown
Contributor

@pacoxu pacoxu commented Jan 23, 2026

Purpose

https://github.com/NVIDIA/cutlass?tab=readme-ov-file#whats-new-in-cutlass-43
https://docs.nvidia.com/cutlass/latest/CHANGELOG.html

cutlass 4.3.5 vs 4.2.1, it includes many Blackwell SM100/SM103/SM120/SM130 support feature/bugfix.

Probably this may benefit PRs like

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@pacoxu pacoxu changed the title Update CUTLASS_REVISION to v4.3.5 [Fix] Update CUTLASS_REVISION to v4.3.5 Jan 23, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CUTLASS dependency from v4.2.1 to v4.3.5 to incorporate support for Blackwell architectures. The modification in CMakeLists.txt is straightforward and correct. However, given that this is a significant dependency update, it has the potential to impact various parts of the system, including kernel generation scripts and other components that rely on CUTLASS. The pull request description currently lacks a test plan and corresponding results. For a change of this nature, it is critical to provide detailed information about the testing performed to validate that the new version does not introduce any regressions and that the intended new functionalities work as expected. Please update the pull request to include a comprehensive test plan and its outcomes.

@mgoin
Copy link
Copy Markdown
Member

mgoin commented Jan 28, 2026

Let's see if this breaks anything

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 28, 2026
@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Jan 30, 2026


[2026-01-29T06:14:49Z]         # Verify the response reflects the pirate personality
[2026-01-29T06:14:49Z]         output_text = response.output_text.lower()
[2026-01-29T06:14:49Z]         pirate_indicators = ["arrr", "matey", "ahoy", "ye", "sea"]
[2026-01-29T06:14:49Z]         has_pirate_language = any(
[2026-01-29T06:14:49Z]             indicator in output_text for indicator in pirate_indicators
[2026-01-29T06:14:49Z]         )
[2026-01-29T06:14:49Z] >       assert has_pirate_language, (
[2026-01-29T06:14:49Z]             f"Expected pirate language in response, got: {response.output_text}"
[2026-01-29T06:14:49Z]         )
[2026-01-29T06:14:49Z] E       AssertionError: Expected pirate language in response, got: I’m doing well, thanks for asking! How can I help you today?
[2026-01-29T06:14:49Z] E       assert False
[2026-01-29T06:14:49Z]
[2026-01-29T06:14:49Z] entrypoints/openai/responses/test_harmony.py:1268: AssertionError
[2026-01-29T06:14:49Z] =============================== warnings summary ===============================
[2026-01-29T06:14:49Z] <frozen importlib._bootstrap>:488
[2026-01-29T06:14:49Z]   <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute
[2026-01-29T06:14:49Z]
[2026-01-29T06:14:49Z] <frozen importlib._bootstrap>:488
[2026-01-29T06:14:49Z]   <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute
[2026-01-29T06:14:49Z]
[2026-01-29T06:14:49Z] ../../usr/local/lib/python3.12/dist-packages/schemathesis/generation/coverage.py:305
[2026-01-29T06:14:49Z]   /usr/local/lib/python3.12/dist-packages/schemathesis/generation/coverage.py:305: DeprecationWarning: jsonschema.exceptions.RefResolutionError is deprecated as of version 4.18.0. If you wish to catch potential reference resolution errors, directly catch referencing.exceptions.Unresolvable.
[2026-01-29T06:14:49Z]     ref_error: type[Exception] = jsonschema.RefResolutionError,
[2026-01-29T06:14:49Z]
[2026-01-29T06:14:49Z] -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
[2026-01-29T06:14:49Z] =========================== short test summary info ============================
[2026-01-29T06:14:49Z] FAILED entrypoints/openai/responses/test_harmony.py::test_system_prompt_override[openai/gpt-oss-20b] - AssertionError: Expected pirate language in response, got: I’m doing well, thanks for asking! How can I help you today?
[2026-01-29T06:14:49Z] assert False
[2026-01-29T06:14:49Z] !!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
[2026-01-29T06:14:49Z] ======= 1 failed, 45 passed, 1 skipped, 3 warnings in 263.45s (0:04:23) ========
[2026-01-29T06:14:52Z] 🚨 Error: The command exited with status 1
[2026-01-29T06:14:52Z] user command error: The plugin docker command hook exited with status 1

CI failed for test_harmony.py::test_system_prompt_override.

I rebased with latest main branch.

After re-run, this is passed.

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@mergify
Copy link
Copy Markdown

mergify bot commented Feb 3, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @pacoxu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 8, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @pacoxu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 8, 2026
@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Feb 28, 2026

@pacoxu pacoxu closed this Feb 28, 2026
@github-project-automation github-project-automation bot moved this to Done in NVIDIA Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build kv-connector needs-rebase nvidia ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants