Draft
Conversation
5 tasks
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Add SM120 FP8 CUTLASS MoE grouped GEMM kernel, wire runtime dispatch for SM120, and gate build via CMake with CUDA 13+. Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for NVIDIA Blackwell (SM120) architecture for Mixture-of-Experts (MoE) kernels. It updates the CUTLASS revision to v4.3.5, adds CMake logic to conditionally compile a new SM120-specific grouped GEMM kernel, and integrates this kernel into the existing dispatch mechanism. The changes appear to be a well-structured extension of the current MoE kernel infrastructure to support newer hardware capabilities.
Member
|
Have you tried to see if this works? |
|
do you also need this pr? #31089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19757
#32237
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.