[Hardware][AMD][CI][Bugfix] Fix regressions from deprecated env vars#32837
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Jan 22, 2026
Merged
[Hardware][AMD][CI][Bugfix] Fix regressions from deprecated env vars#32837DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses regressions caused by the deprecation of certain environment variables, particularly VLLM_V1_USE_PREFILL_DECODE_ATTENTION and VLLM_ATTENTION_BACKEND. The changes ensure that the ROCM_ATTN backend is correctly selected even when the vLLM configuration might not be fully initialized, and updates the CI/CD scripts to pass the ROCM_ATTN flag as an environment variable. The modifications enhance the robustness of the attention backend selection logic and ensure the accuracy tests run as expected.
tjtanaa
approved these changes
Jan 22, 2026
Collaborator
tjtanaa
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the quick fix.
Contributor
Author
monajafi-amd
pushed a commit
to monajafi-amd/vllm
that referenced
this pull request
Jan 23, 2026
…llm-project#32837) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com> Signed-off-by: mohammad najafi <mohammad.najafi@amd.com>
cwazai
pushed a commit
to cwazai/vllm
that referenced
this pull request
Jan 25, 2026
…llm-project#32837) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com> Signed-off-by: 陈建华 <1647430658@qq.com>
lapy
pushed a commit
to lapy/vllm
that referenced
this pull request
Jan 27, 2026
…llm-project#32837) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…llm-project#32837) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes various issues on AMD ROCm caused by the deprecation of environment variables in #32812.
Firstly, the deprecation of
VLLM_V1_USE_PREFILL_DECODE_ATTENTIONmeans thatget_current_vllm_configis now called as a replacement inRocmPlatform.get_attn_backend_clsto determine if theROCM_ATTNbackend should be used. However, there are instances where the current vLLM config is not yet set, which causes the above function to error.For instance, this causes a test regression in
v1/attention/test_rocm_attention_backends_selection.py::test_standard_attention_backend_selectionSecondly, the deprecation of
VLLM_ATTENTION_BACKENDmeant that the requiredROCM_ATTNbackend was no longer correctly passed to the NIXL accuracy tests, resulting in failing tests.The aforementioned test regressions can be seen on this AMD CI nightly build under the failing
test groups.
Test Plan
Run the following
pytest -sv tests/v1/attention/test_rocm_attention_backends_selection.py -k test_standard_attention_backend_selectionROCM_ATTN=1 bash v1/kv_connector/nixl_integration/config_sweep_accuracy_test.shDP_EP=1 ROCM_ATTN=1 bash v1/kv_connector/nixl_integration/config_sweep_accuracy_test.shas part of the
test groups in AMD CI.
Test Result
The tests now pass.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.