[Hardware][AMD][Bugfix] Fix PTPC FP8 quantization#32813
Open
mawong-amd wants to merge 1 commit intovllm-project:mainfrom
Open
[Hardware][AMD][Bugfix] Fix PTPC FP8 quantization#32813mawong-amd wants to merge 1 commit intovllm-project:mainfrom
mawong-amd wants to merge 1 commit intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the PTPC FP8 quantization implementation. By changing the base class of PTPCFp8LinearMethod from Fp8LinearMethod to Fp8OnlineLinearMethod, the method now correctly inherits the behavior for online quantization, which is its intended purpose. This aligns with the fact that PTPC performs dynamic, on-the-fly quantization of weights rather than loading pre-quantized checkpoints. The change is logical, well-contained, and directly addresses the issue described. I find no issues with this correction.
Contributor
Author
|
Closing since PTPC FP8 is being deprecated soon: #32700 |
5 tasks
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
4e61450 to
61d73ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes PTPC FP8 quantization and thus AMD Quantization Tests after the refactoring done in #32189.
PTPCFP8LinearMethodshould now inherit fromFP8OnlineLinearMethodrather thanFP8LinearMethod.Test Plan
pytest -sv quantization/test_ptpc_fp8.pyThe above is implicitly run as part of AMD CI's Quantization Tests group.
Test Result
The test and test group both pass.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.