[Core] Rename PassConfig flags as per RFC #27995 by arpitkh101 · Pull Request #29646 · vllm-project/vllm

arpitkh101 · 2025-11-28T05:38:09Z

Purpose

Implements the PassConfig flag renaming from issue #27995.

Changes:

Renamed all PassConfig flags to be more descriptive (e.g., enable_fusion → fuse_norm_quant + fuse_act_quant)
Added deprecation warnings for old flag names
Old flags still work for backward compatibility
Updated all internal code and tests to use new names

github-actions · 2025-11-28T05:38:18Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

mergify · 2025-11-28T05:38:45Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @arpitkh101.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

gemini-code-assist

Code Review

This pull request refactors PassConfig flags to be more descriptive, which is a great improvement for clarity. The changes are mostly mechanical renames across the test suite and configuration files. However, I've found a critical issue in the backward compatibility logic for the deprecated flags in vllm/config/compilation.py. The current implementation incorrectly handles cases where old flags are set to False, which would unintentionally enable features. I've provided a suggestion to fix this to ensure correct behavior.

vllm/config/compilation.py

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

vllm/config/compilation.py

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

ProExpertProg

A few minor notes, looks ready otherwise! Could you also add a test that checks that specifying the old fields results in new fields set correctly and a warning (see #29557 for example)

tests/compile/distributed/test_sequence_parallelism.py

vllm/config/compilation.py

vllm/config/vllm.py

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

tests/compile/distributed/test_sequence_parallelism.py

tests/compile/test_config.py

vllm/config/compilation.py

vllm/config/utils.py

vllm/config/vllm.py

tests/compile/test_config.py

ProExpertProg · 2025-12-02T15:28:48Z

@arpitkh101 will you be able to finish this today so we can include it in the 0.12.0 release?

hmellor · 2025-12-02T15:36:52Z

@arpitkh101 will you be able to finish this today so we can include it in the 0.12.0 release?

If not, we should bump the removal version. Deprecation messges must be present for a whole minor version.

arpitkh101 · 2025-12-02T16:18:49Z

I think I'll be able to push these changes today.

ProExpertProg · 2025-12-02T17:23:36Z

I think I'll be able to push these changes today.

@arpitkh101 please keep us posted! Someone else can pick up and help if you're not able to finish today, would really like to get this in for this release!

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

…flags with None Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> (cherry picked from commit d7284a2)

hmellor

Couple of nits, not necessary for the release but would be nice to clean up asap.

vllm/config/compilation.py

Signed-off-by: leo-pony <nengjunma@outlook.com>

…oject#29646) Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>

arpitkh101 requested review from ProExpertProg, WoosukKwon, hmellor, houseroad, mgoin, robertgshaw2-redhat, tlrmchlsmth, yewentao256, youkaichao and zou3519 as code owners November 28, 2025 05:38

mergify bot added the v1 label Nov 28, 2025

mergify bot added the needs-rebase label Nov 28, 2025

gemini-code-assist bot reviewed Nov 28, 2025

View reviewed changes

vllm/config/compilation.py Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Nov 28, 2025

View reviewed changes

vllm/config/compilation.py Outdated Show resolved Hide resolved

hmellor reviewed Nov 28, 2025

View reviewed changes

vllm/config/compilation.py Outdated Show resolved Hide resolved

rename passconfig flags

ee0a62a

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

arpitkh101 force-pushed the rename-passconfig-flags branch from 15411fa to 0c4eb98 Compare November 29, 2025 04:22

mergify bot removed the needs-rebase label Nov 29, 2025

Add utility for deprecated flag warnings

289336c

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

arpitkh101 force-pushed the rename-passconfig-flags branch from ece81a1 to 289336c Compare November 29, 2025 05:43

ProExpertProg reviewed Nov 29, 2025

View reviewed changes

Add deprecation versions and tests and fix minor issues.

63ba004

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

ProExpertProg reviewed Dec 2, 2025

View reviewed changes

ProExpertProg added this to the v0.12.0 milestone Dec 2, 2025

Minor fixes

2b96f69

Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

ProExpertProg approved these changes Dec 2, 2025

View reviewed changes

ProExpertProg enabled auto-merge (squash) December 2, 2025 18:19

github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 2, 2025

Add old flags to the PassConfig's field validator and initialize new …

facc7fe

…flags with None Signed-off-by: arpitkh101 <arpit5khandelwal@gmail.com>

auto-merge was automatically disabled December 2, 2025 21:19
Head branch was pushed to by a user without write access

Merge branch 'main' into rename-passconfig-flags

8a29c8d

ProExpertProg enabled auto-merge (squash) December 2, 2025 22:41

Merge branch 'main' into rename-passconfig-flags

85de54b

ProExpertProg merged commit d7284a2 into vllm-project:main Dec 3, 2025
53 checks passed

hmellor reviewed Dec 3, 2025

View reviewed changes

vllm/config/compilation.py Show resolved Hide resolved

vllm/config/compilation.py Show resolved Hide resolved

ProExpertProg linked an issue Dec 3, 2025 that may be closed by this pull request

[RFC]: Make PassConfig flags less verbose #27995

Closed

1 task

arpitkh101 mentioned this pull request Dec 3, 2025

[Core] Remove forced None assignment for deprecated PassConfig flags #29994

Merged

MengqingCao mentioned this pull request Dec 8, 2025

[Misc] Fix enable_sequence_parallelism in PassConfig vllm-project/vllm-ascend#4767

Closed

leo-pony added a commit to Toneymiller/vllm-ascend that referenced this pull request Dec 16, 2025

fix break rename enable_sequence_parallelism:vllm-project/vllm#29646

83b4390

Signed-off-by: leo-pony <nengjunma@outlook.com>

mgoin mentioned this pull request Dec 16, 2025

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_group_quant #30817

Merged

5 tasks

Toneymiller mentioned this pull request Dec 17, 2025

Upgrade vllm commit hash to 1216 vllm-project/vllm-ascend#5053

Merged

3manifold mentioned this pull request Dec 19, 2025

vLLM 0.13.0 causes error due to deprecated VLLM_ATTENTION_BACKEND environment variable modelscope/ms-swift#7132

Open

ptarasiewiczNV mentioned this pull request Jan 30, 2026

chore: Update vLLM compilation config to vLLM v0.14.1 ai-dynamo/dynamo#5819

Merged

Uh oh!

Conversation

arpitkh101 commented Nov 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

mergify bot commented Nov 28, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ProExpertProg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ProExpertProg commented Dec 2, 2025

Uh oh!

hmellor commented Dec 2, 2025

Uh oh!

arpitkh101 commented Dec 2, 2025

Uh oh!

ProExpertProg commented Dec 2, 2025

Uh oh!

Uh oh!

hmellor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arpitkh101 commented Nov 28, 2025 •

edited by github-actions bot

Loading