Replace deprecated enable_fusion with fuse_norm_quant in test_rms_group_quant by mgoin · Pull Request #30817 · vllm-project/vllm

mgoin · 2025-12-16T22:05:34Z

Purpose

Landing strict config matching in #30708 caused this test to start to fail
https://buildkite.com/vllm/ci/builds/43658/steps/canvas?sid=019b2408-04fa-4f90-be13-3d338355f821#019b2408-0652-4d81-aa1d-60475172b711/86-5524

FAILED tests/compile/distributed/test_fusions_e2e.py::test_rms_group_quant[True-Qwen/Qwen3-30B-A3B-FP8-model_kwargs0-AttentionBackendEnum.TRITON_ATTN-matches0-+quant_fp8,+rms_norm] - pydantic_core._pydantic_core.ValidationError: 1 validation error for PassConfig
enable_fusion
  Unexpected keyword argument [type=unexpected_keyword_argument, input_value=True, input_type=bool]
    For further information visit https://errors.pydantic.dev/2.12/v/unexpected_keyword_argument

PR that removed enable_fusion: #30396 and #29646

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
(Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

…up_quant Signed-off-by: mgoin <mgoin64@gmail.com>

chatgpt-codex-connector · 2025-12-16T22:05:40Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

gemini-code-assist

Code Review

This pull request correctly replaces the deprecated enable_fusion flag with fuse_norm_quant in the test_rms_group_quant test. This change addresses the ValidationError that occurred after enable_fusion was removed, as described in the PR. The fix is direct, accurate, and aligns with the recent changes in the PassConfig API. The code quality is good, and I have no further comments.

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk>

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>

Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_swiftbalancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update parallel.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update __init__.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update type hint for old_global_expert_indices Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update type hint for old_global_expert_indices Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update vllm/distributed/eplb/policy/flashlb.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update vllm/distributed/eplb/policy/swift_balancer.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update vllm/distributed/eplb/eplb_state.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_algo.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Fix assertion message for highest weight expert Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Fix indentation in weight tensor definition Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update abstract.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update default.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk> Replace deprecated enable_fusion with fuse_norm_quant in test_rms_group_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk> eplb fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> add new eplb alog Signed-off-by: raindaywhu <raindaywhu@163.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> fix new eplb algo eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> flashlb_policy added flashlb_policy adjusted flashlb_policy added format fix eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update test_eplb_flashlb.py format fix Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update default_eplb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_swiftbalancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update parallel.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update abstract_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update default_eplb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update default_eplb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> eplb policy fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> format fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> eplb fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> add new eplb alog Signed-off-by: raindaywhu <raindaywhu@163.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> fix new eplb algo eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> flashlb_policy added flashlb_policy adjusted flashlb_policy added format fix eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update test_eplb_flashlb.py format fix Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update default_eplb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_swiftbalancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update parallel.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update abstract_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update default_eplb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update default_eplb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer_policy.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> eplb policy Signed-off-by: Che Ruan <cr623@ic.ac.uk> eplb policy fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> conflict remove Signed-off-by: Che Ruan <cr623@ic.ac.uk> format fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> format fix Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk> add policy factory Signed-off-by: Che Ruan <cr623@ic.ac.uk> type declare Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update test_eplb_flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_swiftbalancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update parallel.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update __init__.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update type hint for old_global_expert_indices Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update type hint for old_global_expert_indices Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update vllm/distributed/eplb/policy/flashlb.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update vllm/distributed/eplb/policy/swift_balancer.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update vllm/distributed/eplb/eplb_state.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update test_eplb_algo.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Fix assertion message for highest weight expert Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Fix indentation in weight tensor definition Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update abstract.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update default.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update flashlb.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update policy_factory.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk> Update swift_balancer.py Signed-off-by: mengxingkongzhouhan <117415539+mengxingkongzhouhan@users.noreply.github.com> Update test_swiftbalancer.py Signed-off-by: Mercykid-bash <ruanche0218@gmail.com> Update swift_balancer.py Signed-off-by: mengxingkongzhouhan <117415539+mengxingkongzhouhan@users.noreply.github.com>

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

f9a345f

…up_quant Signed-off-by: mgoin <mgoin64@gmail.com>

gemini-code-assist bot reviewed Dec 16, 2025

View reviewed changes

mgoin added ready ONLY add when PR is ready to merge/full CI is needed ci-failure Issue about an unexpected test failure in CI labels Dec 16, 2025

github-project-automation bot added this to CI Failures Dec 16, 2025

khluu added this to the v0.13.0 milestone Dec 16, 2025

ProExpertProg approved these changes Dec 16, 2025

View reviewed changes

ProExpertProg enabled auto-merge (squash) December 16, 2025 22:23

ProExpertProg merged commit e80455c into vllm-project:main Dec 16, 2025
26 checks passed

github-project-automation bot moved this to Done in CI Failures Dec 16, 2025

Mercykid-bash pushed a commit to raindaywhu/vllm that referenced this pull request Dec 17, 2025

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

d6c973e

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Che Ruan <cr623@ic.ac.uk>

NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Dec 17, 2025

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

8d71371

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

yugong333 pushed a commit to yugong333/vllm that referenced this pull request Feb 5, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

649213a

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

atalhens pushed a commit to atalhens/vllm that referenced this pull request Feb 6, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

8cb59c4

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

yugong333 pushed a commit to yugong333/vllm that referenced this pull request Feb 11, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

fba96d4

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

yugong333 pushed a commit to yugong333/vllm that referenced this pull request Feb 13, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

0ce7e8a

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

d89ac92

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

yugong333 pushed a commit to yugong333/vllm that referenced this pull request Feb 26, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

18e30d6

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

yugong333 pushed a commit to yugong333/vllm that referenced this pull request Feb 27, 2026

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_gro…

0e0a670

…up_quant (vllm-project#30817) Signed-off-by: mgoin <mgoin64@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_group_quant#30817

Replace deprecated enable_fusion with fuse_norm_quant in test_rms_group_quant#30817
ProExpertProg merged 1 commit intovllm-project:mainfrom
neuralmagic:fix-fusions-e2e-enable_fusions

mgoin commented Dec 16, 2025 •

edited by github-actions bot

Loading

Uh oh!

chatgpt-codex-connector bot commented Dec 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mgoin commented Dec 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Test Plan

Test Result

Uh oh!

chatgpt-codex-connector bot commented Dec 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mgoin commented Dec 16, 2025 •

edited by github-actions bot

Loading