[CI] Resettle pooling entrypoints tests. #29370
[CI] Resettle pooling entrypoints tests. #29370DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
|
I think we should still separate online and offline tests, because the fixtures they use are different. |
There was a problem hiding this comment.
Code Review
This pull request is a pure refactoring of the pooling entrypoint tests. The tests have been reorganized into subdirectories based on their use case, such as basic, classify, embed, and score. This change significantly improves the structure and maintainability of the test suite, making it easier to navigate and locate specific tests. The new organization is logical and well-structured. As the PR only contains file moves and renames with no code modifications, there are no code-level issues to address. The refactoring is a positive change for the project.
|
Also, in order to better integrate with our CI refactoring, it is better for the tests to match the code organization in vLLM, so we can automatically detect which tests to run based on matching directories. |
I plan to gradually refactor the pooling entrypoints to have the same layout as this test. What do you think? and examples |
|
We have a more extensive plan for this, see #27882 (review) |
I think there’s more code that can be reused (e.g. render)between the online and offline versions for the same use case. Code from the same provider is hardly reusable across different use cases. APIs should be organized by use case, not by provider. |
|
|
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Purpose
Resettle pooling entrypoints tests by use cases.
cc @DarkLight1337
Test Plan
tests/entrypoints/pooling/
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.