Skip to content

[examples] Resettle pooling examples.#29365

Merged
hmellor merged 13 commits intovllm-project:mainfrom
noooop:resettle_pooling_examples
Dec 2, 2025
Merged

[examples] Resettle pooling examples.#29365
hmellor merged 13 commits intovllm-project:mainfrom
noooop:resettle_pooling_examples

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Nov 25, 2025 •
edited by github-actions bot
Loading

Purpose

Resettle pooling examples.

Following #29362

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@noooop
init
eda9030 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link

mergify bot commented Nov 25, 2025

Documentation preview: https://vllm--29365.org.readthedocs.build/en/29365/

@mergify mergify bot added documentation Improvements or additions to documentation qwen Related to Qwen models labels Nov 25, 2025
@noooop noooop mentioned this pull request Nov 25, 2025
Merged
5 tasks
noooop added 2 commits December 1, 2025 17:02
@noooop
Merge branch 'main' into resettle_pooling_examples
726b972
@noooop
init
7486bd4 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify bot added the ci/build label Dec 1, 2025
@noooop noooop marked this pull request as ready for review December 1, 2025 09:27
@noooop noooop requested a review from hmellor as a code owner December 1, 2025 09:27
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 1, 2025

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@noooop noooop marked this pull request as draft December 1, 2025 09:27
noooop and others added 3 commits December 1, 2025 17:50
@noooop
fix links
6542557 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop
fix
8fe3ed8 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@hmellor
Update nav for transitioning example location
0f336ce 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
hmellor reviewed Dec 1, 2025
View reviewed changes
@hmellor
Update generate examples to populate the new structure
690db9d 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Revert unrelated change
1f09e85 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Move all nav
b632f06 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
If multi file with no readme, one section per file
28488ad 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Copy link
Member

hmellor commented Dec 1, 2025 •
edited
Loading

I've updated the example generation and the nav so that the new location of the pooling examples renders really nicely in the docs

@hmellor
Copy link
Member

hmellor commented Dec 1, 2025

Preview from my local build:

image

@noooop noooop marked this pull request as ready for review December 2, 2025 02:11
@noooop
Copy link
Collaborator Author

noooop commented Dec 2, 2025

I've updated the example generation and the nav so that the new location of the pooling examples renders really nicely in the docs

Thanks for your help, pooling examples look great now.

@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 2, 2025
noooop added 2 commits December 2, 2025 11:31
@noooop
fix
67aab22 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop
fix
70ddc17 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop requested a review from hmellor December 2, 2025 05:03
@hmellor hmellor merged commit 2eb4fe9 into vllm-project:main Dec 2, 2025
15 checks passed
@noooop noooop deleted the resettle_pooling_examples branch December 3, 2025 02:02
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
@noooop @hmellor @dsuhinin
[examples] Resettle pooling examples. (vllm-project#29365)
97b3d35 
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noooop @hmellor