Skip to content

Comments

[Frontend][Renderer] Refactor score API#28631

Draft
noooop wants to merge 9 commits intovllm-project:mainfrom
noooop:Refactor_score_api
Draft

[Frontend][Renderer] Refactor score API#28631
noooop wants to merge 9 commits intovllm-project:mainfrom
noooop:Refactor_score_api

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Nov 13, 2025

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the frontend label Nov 13, 2025
@mergify
Copy link

mergify bot commented Nov 13, 2025

Documentation preview: https://vllm--28631.org.readthedocs.build/en/28631/

@mergify mergify bot added documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) labels Nov 13, 2025
@noooop noooop changed the title [Frontend] Refactor score API [Frontend][Renderer] Refactor score API Nov 14, 2025
@mergify
Copy link

mergify bot commented Dec 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @noooop.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 1, 2025
@noooop noooop closed this Feb 5, 2026
@noooop noooop force-pushed the Refactor_score_api branch from 87f179e to a7be77b Compare February 5, 2026 02:01
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop reopened this Feb 6, 2026
@mergify
Copy link

mergify bot commented Feb 6, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @noooop.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot removed the needs-rebase label Feb 6, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Comment on lines 74 to 84
if self.is_cross_encoder:
from .preprocessor import CrossEncoderPreProcessor

self.preprocessor = CrossEncoderPreProcessor(
model_config=self.model_config,
renderer=self.renderer,
io_processor=self.io_processor,
input_processor=self.input_processor,
score_template=self.score_template,
)
self._score_func = self._cross_encoding_score
Copy link
Collaborator Author

@noooop noooop Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarkLight1337

I tried to extract the preprocessing of score, temporarily naming this as XXXPreProcessor, but we already have renderer, io_processor, and input_processor for preprocessing. May I ask which layer of abstraction should I align this preprocessing class with?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking of adding some sort of "hooks" to the IO processor that modify the prompt inputs.

)


class PoolingIOProcessor:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants