[Frontend][Renderer] Refactor score API#28631
Draft
noooop wants to merge 9 commits intovllm-project:mainfrom
Draft
[Frontend][Renderer] Refactor score API#28631noooop wants to merge 9 commits intovllm-project:mainfrom
noooop wants to merge 9 commits intovllm-project:mainfrom
Conversation
|
Documentation preview: https://vllm--28631.org.readthedocs.build/en/28631/ |
This was referenced Nov 25, 2025
|
This pull request has merge conflicts that must be resolved before it can be |
87f179e to
a7be77b
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
noooop
commented
Feb 9, 2026
noooop
commented
Feb 9, 2026
5 tasks
noooop
commented
Feb 12, 2026
Comment on lines
74
to
84
| if self.is_cross_encoder: | ||
| from .preprocessor import CrossEncoderPreProcessor | ||
|
|
||
| self.preprocessor = CrossEncoderPreProcessor( | ||
| model_config=self.model_config, | ||
| renderer=self.renderer, | ||
| io_processor=self.io_processor, | ||
| input_processor=self.input_processor, | ||
| score_template=self.score_template, | ||
| ) | ||
| self._score_func = self._cross_encoding_score |
Collaborator
Author
There was a problem hiding this comment.
I tried to extract the preprocessing of score, temporarily naming this as XXXPreProcessor, but we already have renderer, io_processor, and input_processor for preprocessing. May I ask which layer of abstraction should I align this preprocessing class with?
Member
There was a problem hiding this comment.
I am thinking of adding some sort of "hooks" to the IO processor that modify the prompt inputs.
noooop
commented
Feb 12, 2026
| ) | ||
|
|
||
|
|
||
| class PoolingIOProcessor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
OpenAIServing._preprocess_*withProcessor.process_inputs#23873 [RFC]: Unified Input Formatting and Processing viaRenderer#22880jinaai/jina-reranker-v3new reranking model #28557Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.