Skip to content

Comments

[Frontend] Resettle pooling entrypoints #29634

Merged
DarkLight1337 merged 17 commits intovllm-project:mainfrom
noooop:resettle_pooling_entrypoints
Dec 1, 2025
Merged

[Frontend] Resettle pooling entrypoints #29634
DarkLight1337 merged 17 commits intovllm-project:mainfrom
noooop:resettle_pooling_entrypoints

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Nov 28, 2025

Purpose

Currently, we have two entrypoints refactoring plans.

Merge this PR first, hoping to reduce conflicts.

├─pooling
│  ├─classify
│  ├─embed
│  ├─pooling
│  ├─score
│  │  ├─api_router
│  │  ├─protocol
│  │  └─serving

Test Plan

pytest tests/entrypoints/pooling/

Test Result

pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link

mergify bot commented Nov 28, 2025

Documentation preview: https://vllm--29634.org.readthedocs.build/en/29634/

@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend labels Nov 28, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop marked this pull request as ready for review November 28, 2025 08:08
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link

mergify bot commented Dec 1, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @noooop.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 1, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify bot removed the needs-rebase label Dec 1, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 1, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop requested a review from DarkLight1337 December 1, 2025 06:59
@DarkLight1337 DarkLight1337 merged commit 62de4f4 into vllm-project:main Dec 1, 2025
50 checks passed
@noooop noooop deleted the resettle_pooling_entrypoints branch December 1, 2025 07:32
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
amd-hhashemi pushed a commit to amd-hhashemi/vllm that referenced this pull request Dec 2, 2025
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants