[Compile] Fix import error of vllm._C#26077
[Compile] Fix import error of vllm._C#26077ZJY0516 wants to merge 6 commits intovllm-project:mainfrom
vllm._C#26077Conversation
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a build issue that was causing an ImportError due to an undefined symbol. The error was introduced in a previous pull request that removed nvfp4_blockwise_moe_kernel.cu from the list of compiled sources. This change re-adds the file to CMakeLists.txt, which resolves the issue. The fix is straightforward and effective. I have reviewed the change and found no issues.
ProExpertProg
left a comment
There was a problem hiding this comment.
We should instead just guard its use in torch_bindings.cpp on the arch supporting fp4 (and the cudaversion)
| "csrc/quantization/fp4/activation_nvfp4_quant_fusion_kernels.cu" | ||
| "csrc/quantization/fp4/nvfp4_experts_quant.cu" | ||
| "csrc/quantization/fp4/nvfp4_scaled_mm_kernels.cu" | ||
| "csrc/quantization/fp4/nvfp4_blockwise_moe_kernel.cu") |
There was a problem hiding this comment.
It's added to sources here
I didn't seen similar pattern like this in |
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
ProExpertProg
left a comment
There was a problem hiding this comment.
Thanks for reworking this
|
#26138 does it in a cleaner way actually |
|
Closing as superseded by #26138 |
Purpose
PR #24673 removes
nvfp4_blockwise_moe_kernel.cufromVLLM_EXT_SRC, which will cause an import error when using vllm built from source.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.