[Bugfix] Fix build issue around cutlass_fp4_group_mm on platforms without nvfp4#26061
[Bugfix] Fix build issue around cutlass_fp4_group_mm on platforms without nvfp4#26061StrongerXi wants to merge 1 commit intovllm-project:mainfrom
cutlass_fp4_group_mm on platforms without nvfp4#26061Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request aims to fix a build issue for cutlass_fp4_group_mm on platforms without nvfp4 support by introducing a dispatch file. The approach is correct, but there is a critical error in the implementation of the new dispatch function that will cause a compilation failure. I've provided a fix for this issue.
| @@ -367,7 +367,7 @@ constexpr auto SF_DTYPE = at::ScalarType::Float8_e4m3fn; | |||
| CHECK_CONTIGUOUS(x, m); \ | |||
| CHECK_TYPE(x, st, m) | |||
|
|
|||
| void cutlass_fp4_group_mm( | |||
There was a problem hiding this comment.
This file isn't always included in the build, I think that's why I ran into the undefined symbol error
Lines 600 to 606 in 1726e93
…ithout nvfp4 Fixes the undefined symbol issue (vllm-project#23925 (comment)) by keeping the function definition of `cutlass_fp4_group_mm` even on non-nvfp4-supported platforms in `csrc/quantization/fp4/nvfp4_blockwise_moe_entry.cu`. Similar to vllm-project#23727.
|
This should be covered by #26077 |
Purpose
Fixes the undefined symbol issue (#23925 (comment)) by keeping the function definition of
cutlass_fp4_group_mmeven on non-nvfp4-supported platforms incsrc/quantization/fp4/nvfp4_blockwise_moe_entry.cu.Similar to #23727.
Test Plan
Existing tests and build pass on platform without nvfp4 support (H100 in my case).
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.