[CI/Build] Conditionally register cutlass_fp4_group_mm to fix building on Hopper#26138
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Oct 3, 2025
Merged
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly resolves a build issue on Hopper systems by conditionally registering the cutlass_fp4_group_mm operator. Moving the implementation registration into the same compilation unit (nvfp4_blockwise_moe_kernel.cu) as the function definition ensures that the operator is only registered when it is actually compiled, thus preventing linker errors. The approach is consistent with how other conditionally compiled operators are handled in the codebase. The changes are clean, targeted, and effectively address the problem.
ProExpertProg
approved these changes
Oct 3, 2025
5 tasks
5 tasks
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…g on Hopper (#26138) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
…g on Hopper (vllm-project#26138) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan
pushed a commit
to karan/vllm
that referenced
this pull request
Oct 6, 2025
…g on Hopper (vllm-project#26138) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…g on Hopper (vllm-project#26138) Signed-off-by: mgoin <mgoin64@gmail.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…g on Hopper (vllm-project#26138) Signed-off-by: mgoin <mgoin64@gmail.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…g on Hopper (vllm-project#26138) Signed-off-by: mgoin <mgoin64@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…g on Hopper (vllm-project#26138) Signed-off-by: mgoin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
cutlass_fp4_group_mmwas unconditionally registered intorch_bindings.cppeven though its implementation is only compiled whenENABLE_NVFP4_SM100is defined, causing undefined symbol errors on Hopper.This fix moves the
ops.implregistration to be conditionally compiled withinnvfp4_blockwise_moe_kernel.cuusingTORCH_LIBRARY_IMPL_EXPAND, matching the pattern used by other conditionally-compiled operations likecutlass_blockwise_scaled_grouped_mm.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.