Repository navigation
[CI/Build][ROCm] Run Hunyuan reliability without expert parallel - #9428
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR appears to belong to: docs/design/module/vllm_omni_config.md, docs/design/module/entrypoints.md. Module owners: @alex-jw-brooks @lishunyang12 @NickCao Routing: @alex-jw-brooks via module of the changed files, CODEOWNERS; @lishunyang12 via module of the changed files, CODEOWNERS; @NickCao via module of the changed files, CODEOWNERS @hacZ17, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
f9efc69 to
5fe8c90
Compare
5fe8c90 to
88e4c4b
Compare
88e4c4b to
b7f7994
Compare
The weekly process-kill matrix was dying in the healthy TP=4 expert-parallel warmup before any fault was injected. Keep that path as one non-blocking baseline, and point ROCm fault injection at an overlay with expert parallel off. Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com> Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com>
b7f7994 to
a311af7
Compare
|
Exact-head qualification for a311af7 (rebased onto main 4c51b23):
The rebase preserved #9435's AMD pipeline additions and resolved the shared test constant without changing #9428's behavior. No actionable findings remain. |
Summary
hunyuan_image3_dit_rocm_reliability.yaml, which keeps TP=4 and setsenable_expert_parallel: false.hunyuan_image3_dit.yamlwith expert parallel on.Why this is not a duplicate
No open PR splits the HunyuanImage reliability deploy this way. This does not change the Qwen OOM recovery server set in #9425.
Contributor intent
AI assistance disclosure
Cursor, using Grok 4.7, drafted the deploy overlay, the weekly baseline job, and this description. The human contributor directed this containment for the case where only expert-parallel-on fails. The four-case vLLM 0.31/0.32 comparison was not rerun on this machine. Local contract tests passed. The MI300 jobs have not been run at this head.
Test plan
.venv/bin/python -m pytest tests/buildkite/test_amd_pipeline.py::test_hunyuan_rocm_reliability_disables_expert_parallel tests/buildkite/test_amd_pipeline.py::test_weekly_reliability_is_distinct_from_nightly tests/buildkite/test_amd_suite_selection.py::test_debug_weekly_selects_four_unconditional_jobs -p no:shard --override-ini='addopts='— 3 passedBase:
c84638f3208f0fffd872200adfc5860103a6244bHead:
f9efc69a0415547ce9396dd094ab8cf2804309eeNeed help on this PR? Tag
@codesmith-botwith what you need.