[CI]Upgrade niglty multi-node-tests max-parallel to 2#7035
[CI]Upgrade niglty multi-node-tests max-parallel to 2#7035wangxiyuan merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Kubernetes resource templates used for nightly multi-node tests. By making the names of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request parameterizes the LeaderWorkerSet name in the Kubernetes configuration templates for multi-node tests. This is a good improvement that allows running multiple test instances in parallel without resource name conflicts. The code changes themselves are correct.
However, the pull request title and description do not follow the format specified in the repository's style guide. The title has a typo ('niglty' instead of 'nightly') and should be prefixed with [Module][Action] tags. The description should provide more context about the changes. I have provided suggestions below to align with the style guide, as per rules 1-11 and 41-61 of the repository style guide.
Suggested PR Title:
[Test][Misc] Upgrade nightly multi-node-tests max-parallel to 2Suggested PR Summary:
### What this PR does / why we need it?
This PR parameterizes the `LeaderWorkerSet` name in the Kubernetes configuration templates (`lws-a2.yaml.jinja2` and `lws.yaml.jinja2`). Previously, the name was hardcoded as `vllm`, which prevented running multiple multi-node tests in parallel due to Kubernetes resource name conflicts.
By replacing the hardcoded name with a Jinja2 variable `{{ lws_name | default("vllm") }}`, we can now create multiple `LeaderWorkerSet` instances with unique names. This change enables increasing the parallelism of the nightly multi-node tests to 2.
### Does this PR introduce _any_ user-facing change?
No, this change only affects the E2E test infrastructure and has no user-facing impact.
### How was this patch tested?
CI will validate these changes by running the multi-node tests.
zhangxinyuehfad
force-pushed
the
zxy_fix_nigtly
branch
from
2d15bbe to
7e17512
Compare
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
zhangxinyuehfad
force-pushed
the
zxy_fix_nigtly
branch
from
7e17512 to
235156a
Compare
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
zhangxinyuehfad
force-pushed
the
zxy_fix_nigtly
branch
from
d895070 to
c668b4c
Compare
zhangxinyuehfad
changed the title
|
/nightly deepseek-r1-0528-w8a8 deepseek-r1-0528-w8a8-prefix-cache |
…to qwen3next_graph * 'main' of https://github.com/vllm-project/vllm-ascend: (88 commits) [main][bugfix] Fixed the problem of speculative decoding in FULL mode (vllm-project#7148) fixed fia pad logic in graph mode. (vllm-project#7144) [Doc] fix DSV3.1 PD configs (vllm-project#7187) refactor: add a check before layer_sharding logging (vllm-project#7186) [Build] Add support for Ascend950 chip (vllm-project#7151) Revert "[CI] fix skiped e2e test when upgrade vllm version (vllm-project#6654)" (vllm-project#7166) [MODELRUNNERV2]fix penality ops (vllm-project#7013) [Bugfix][LoRA] Fix the issue when enable LoRA + tp + fully_sharded_loras (vllm-project#6650) [KV Pool]get_num_new_matched_tokens return 0 if token length < block_size (vllm-project#7146) [CI] Build Image for v0.16.0rc1 (vllm-project#7155) [CI] Skip `test_mooncake_layerwise_connector.py` in `ut` (vllm-project#7147) [BugFix]Fix recomputed scheduler bug (vllm-project#7137) [Model] Support Minimax-m2.5 on NPU (vllm-project#7105) [P/D]Mooncake Layerwise Connector supports hybrid attention manager with multiple kvcache groups (vllm-project#7022) Add patch_qwen3_5 for triton ops fused_recurrent_gated_delta_rule (vllm-project#7109) [Doc][ReleaseNote] Add release notes for v0.16.0rc1 (vllm-project#7067) [Misc] Download on both hk and guiyang region (vllm-project#7129) [bugdix] The problem that the w4a8 weight fails to be loaded when the EP is not enabled is resolved. (vllm-project#7090) [eagle][cp] fix eagle_cp enable bug2 (vllm-project#7079) [CI]Upgrade niglty multi-node-tests max-parallel to 2 (vllm-project#7035) ...
) ### What this PR does / why we need it? 1. Increase nightly multi-node test max-parallel from 1 to 2, and fix resource conflicts that arise when tests run concurrently. 2. Fix parse-trigger job: Add an if condition so it only runs on schedule, workflow_dispatch, or PRs labeled nightly-test 3. Adjust nightly schedule: Shift trigger time from 24:00 to 23:45 (UTC+8) ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.16.0 - vLLM main: vllm-project/vllm@4034c3d --------- Signed-off-by: hfadzxy <starmoon_zhang@163.com>
2 participants
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?