[CI] fix skiped e2e test when upgrade vllm version #6654
[CI] fix skiped e2e test when upgrade vllm version #6654wangxiyuan merged 1 commit intovllm-project:mainfrom
Conversation
Summary of ChangesHello @Meihan-chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a continuous integration issue by re-enabling two previously skipped end-to-end tests. These tests, related to ACLGraph capture/replay and Llama32 LoRA functionality, are now integrated back into the CI pipeline to ensure comprehensive validation, particularly after VLLM version upgrades. This change improves the robustness of the testing suite and prevents regressions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request re-enables two end-to-end tests by removing the @pytest.mark.skip decorator. While the change is straightforward, the pull request description is empty and the title has a typo ('skiped'). To align with the repository's style guide and improve clarity, I've suggested an updated title and a complete summary below. Please update the pull request accordingly.
Suggested PR Title:
[Test][BugFix] Re-enable skipped E2E testsSuggested PR Summary:
### What this PR does / why we need it?
This PR re-enables two end-to-end tests that were previously skipped with a "fix me" reason:
- `test_models_aclgraph_capture_replay_metrics_dp2` in `tests/e2e/multicard/2-cards/test_aclgraph_capture_replay.py`
- `test_llama_lora` in `tests/e2e/singlecard/test_llama32_lora.py`
These tests were likely disabled temporarily and are now being re-activated, possibly due to fixes related to a vLLM version upgrade as indicated in the PR title.
### Does this PR introduce _any_ user-facing change?
No, this only affects the test suite.
### How was this patch tested?
The CI will run the re-enabled tests to verify they pass.|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
1f7fad1 to
7e13756
Compare
99a44ee to
e527e90
Compare
…7166) This reverts commit f6db47f. - vLLM version: v0.16.0 - vLLM main: vllm-project/vllm@4034c3d Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
…to qwen3next_graph * 'main' of https://github.com/vllm-project/vllm-ascend: (88 commits) [main][bugfix] Fixed the problem of speculative decoding in FULL mode (vllm-project#7148) fixed fia pad logic in graph mode. (vllm-project#7144) [Doc] fix DSV3.1 PD configs (vllm-project#7187) refactor: add a check before layer_sharding logging (vllm-project#7186) [Build] Add support for Ascend950 chip (vllm-project#7151) Revert "[CI] fix skiped e2e test when upgrade vllm version (vllm-project#6654)" (vllm-project#7166) [MODELRUNNERV2]fix penality ops (vllm-project#7013) [Bugfix][LoRA] Fix the issue when enable LoRA + tp + fully_sharded_loras (vllm-project#6650) [KV Pool]get_num_new_matched_tokens return 0 if token length < block_size (vllm-project#7146) [CI] Build Image for v0.16.0rc1 (vllm-project#7155) [CI] Skip `test_mooncake_layerwise_connector.py` in `ut` (vllm-project#7147) [BugFix]Fix recomputed scheduler bug (vllm-project#7137) [Model] Support Minimax-m2.5 on NPU (vllm-project#7105) [P/D]Mooncake Layerwise Connector supports hybrid attention manager with multiple kvcache groups (vllm-project#7022) Add patch_qwen3_5 for triton ops fused_recurrent_gated_delta_rule (vllm-project#7109) [Doc][ReleaseNote] Add release notes for v0.16.0rc1 (vllm-project#7067) [Misc] Download on both hk and guiyang region (vllm-project#7129) [bugdix] The problem that the w4a8 weight fails to be loaded when the EP is not enabled is resolved. (vllm-project#7090) [eagle][cp] fix eagle_cp enable bug2 (vllm-project#7079) [CI]Upgrade niglty multi-node-tests max-parallel to 2 (vllm-project#7035) ...
### What this PR does / why we need it? fix skiped test_aclgraph_capture_replay.py when upgrade vllm version ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
…ect#6654)" (vllm-project#7166) This reverts commit f6db47f. - vLLM version: v0.16.0 - vLLM main: vllm-project/vllm@4034c3d Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
What this PR does / why we need it?
fix skiped test_aclgraph_capture_replay.py when upgrade vllm version
Does this PR introduce any user-facing change?
How was this patch tested?