Skip to content

[CI] fix skiped e2e test when upgrade vllm version #6654

Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom
Meihan-chen:fix_ut_main
Mar 10, 2026
Merged

[CI] fix skiped e2e test when upgrade vllm version #6654
wangxiyuan merged 1 commit intovllm-project:mainfrom
Meihan-chen:fix_ut_main

Conversation

@Meihan-chen
Copy link
Copy Markdown
Collaborator

@Meihan-chen Meihan-chen commented Feb 10, 2026

What this PR does / why we need it?

fix skiped test_aclgraph_capture_replay.py when upgrade vllm version

Does this PR introduce any user-facing change?

How was this patch tested?

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Meihan-chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a continuous integration issue by re-enabling two previously skipped end-to-end tests. These tests, related to ACLGraph capture/replay and Llama32 LoRA functionality, are now integrated back into the CI pipeline to ensure comprehensive validation, particularly after VLLM version upgrades. This change improves the robustness of the testing suite and prevents regressions.

Highlights

  • E2E Test Re-enablement: Re-enabled the test_aclgraph_capture_replay end-to-end test by removing the @pytest.mark.skip decorator, allowing it to run as part of the CI pipeline.
  • Llama LoRA Test Activation: Activated the test_llama_lora end-to-end test by removing its @pytest.mark.skip decorator, ensuring its execution during CI to validate Llama32 LoRA functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/e2e/multicard/2-cards/test_aclgraph_capture_replay.py
    • Removed the @pytest.mark.skip decorator from the _run_worker_process test function.
  • tests/e2e/singlecard/test_llama32_lora.py
    • Removed the @pytest.mark.skip decorator from the test_llama_lora test function.
Activity
  • No specific activity (comments, reviews, or progress updates) was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables two end-to-end tests by removing the @pytest.mark.skip decorator. While the change is straightforward, the pull request description is empty and the title has a typo ('skiped'). To align with the repository's style guide and improve clarity, I've suggested an updated title and a complete summary below. Please update the pull request accordingly.

Suggested PR Title:

[Test][BugFix] Re-enable skipped E2E tests

Suggested PR Summary:

### What this PR does / why we need it?

This PR re-enables two end-to-end tests that were previously skipped with a "fix me" reason:
- `test_models_aclgraph_capture_replay_metrics_dp2` in `tests/e2e/multicard/2-cards/test_aclgraph_capture_replay.py`
- `test_llama_lora` in `tests/e2e/singlecard/test_llama32_lora.py`

These tests were likely disabled temporarily and are now being re-activated, possibly due to fixes related to a vLLM version upgrade as indicated in the PR title.

### Does this PR introduce _any_ user-facing change?

No, this only affects the test suite.

### How was this patch tested?

The CI will run the re-enabled tests to verify they pass.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@vllm-ascend-ci vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Feb 10, 2026
@Meihan-chen Meihan-chen force-pushed the fix_ut_main branch 2 times, most recently from 1f7fad1 to 7e13756 Compare February 25, 2026 01:16
@Meihan-chen Meihan-chen requested a review from Yikun as a code owner February 25, 2026 01:21
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
@wangxiyuan wangxiyuan merged commit f6db47f into vllm-project:main Mar 10, 2026
27 checks passed
Meihan-chen added a commit to Meihan-chen/vllm-ascend that referenced this pull request Mar 11, 2026
Meihan-chen added a commit to Meihan-chen/vllm-ascend that referenced this pull request Mar 11, 2026
…ect#6654)"

This reverts commit f6db47f.

Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
MengqingCao pushed a commit that referenced this pull request Mar 11, 2026
…7166)

This reverts commit f6db47f.

- vLLM version: v0.16.0
- vLLM main:
vllm-project/vllm@4034c3d

Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
845473182 pushed a commit to 845473182/vllm-ascend that referenced this pull request Mar 12, 2026
…to qwen3next_graph

* 'main' of https://github.com/vllm-project/vllm-ascend: (88 commits)
  [main][bugfix] Fixed the problem of speculative decoding in FULL mode (vllm-project#7148)
  fixed fia pad logic in graph mode. (vllm-project#7144)
  [Doc] fix DSV3.1 PD configs (vllm-project#7187)
  refactor: add a check before layer_sharding logging (vllm-project#7186)
  [Build] Add support for Ascend950 chip (vllm-project#7151)
  Revert "[CI] fix skiped e2e test when upgrade vllm version  (vllm-project#6654)" (vllm-project#7166)
  [MODELRUNNERV2]fix penality ops (vllm-project#7013)
  [Bugfix][LoRA] Fix the issue when enable LoRA + tp + fully_sharded_loras (vllm-project#6650)
  [KV Pool]get_num_new_matched_tokens return 0 if token length < block_size (vllm-project#7146)
  [CI] Build Image for v0.16.0rc1 (vllm-project#7155)
  [CI] Skip `test_mooncake_layerwise_connector.py` in `ut` (vllm-project#7147)
  [BugFix]Fix recomputed scheduler bug (vllm-project#7137)
  [Model] Support Minimax-m2.5 on NPU (vllm-project#7105)
  [P/D]Mooncake Layerwise Connector supports hybrid attention manager with multiple kvcache groups (vllm-project#7022)
  Add patch_qwen3_5 for triton ops fused_recurrent_gated_delta_rule (vllm-project#7109)
  [Doc][ReleaseNote] Add release notes for v0.16.0rc1 (vllm-project#7067)
  [Misc] Download on both hk and guiyang region (vllm-project#7129)
  [bugdix] The problem that the w4a8 weight fails to be loaded when the EP is not enabled is resolved. (vllm-project#7090)
  [eagle][cp] fix eagle_cp enable bug2 (vllm-project#7079)
  [CI]Upgrade niglty multi-node-tests max-parallel to 2 (vllm-project#7035)
  ...
Nagisa125 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Mar 17, 2026
### What this PR does / why we need it?
fix skiped test_aclgraph_capture_replay.py when upgrade vllm version

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.15.0
- vLLM main:
vllm-project/vllm@1339784

Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Nagisa125 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Mar 17, 2026
…ect#6654)" (vllm-project#7166)

This reverts commit f6db47f.

- vLLM version: v0.16.0
- vLLM main:
vllm-project/vllm@4034c3d

Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants