Skip to content

[CI] Update UT CANN version to 8.5.0 for main branch#6564

Merged
wangxiyuan merged 4 commits intovllm-project:mainfrom
leo-pony:recover_custom_op_compile_env_cfg_m
Feb 6, 2026
Merged

[CI] Update UT CANN version to 8.5.0 for main branch#6564
wangxiyuan merged 4 commits intovllm-project:mainfrom
leo-pony:recover_custom_op_compile_env_cfg_m

Conversation

@leo-pony
Copy link
Copy Markdown
Collaborator

@leo-pony leo-pony commented Feb 5, 2026

What this PR does / why we need it?

Update UT CANN version to 8.5.0

Does this PR introduce any user-facing change?

NA

How was this patch tested?

Test on local host without npu:
ddd395a7-247b-43d3-8224-be43074c0554

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @leo-pony, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the CANN version to 8.5.0 and adapting the build and test infrastructure to accommodate this change. It introduces a mechanism to conditionally compile custom kernels and temporarily skips certain unit tests that are incompatible with the new CANN version's NPU SocName checking, ensuring continued CI pipeline functionality while maintaining core system integrity.

Highlights

  • CANN Version Update: The primary goal of this pull request is to update the UT CANN (Compute Architecture for Neural Networks) version to 8.5.0 for the main branch.
  • Conditional Custom Kernel Compilation: Custom kernel compilation in setup.py is now conditional, controlled by a new environment variable COMPILE_CUSTOM_KERNELS. This allows for disabling compilation in environments without an NPU, particularly for unit testing.
  • Test Skipping for CANN 8.5.0 Compatibility: Several unit tests related to layernorm, token_dispatcher, and utils have been marked to be skipped. This is a temporary measure due to register_kernels introducing NPU SocName checking in CANN 8.5.0, which affects test execution in certain environments.
  • New Environment Variable: A new environment variable, COMPILE_CUSTOM_KERNELS, has been introduced in vllm_ascend/envs.py to explicitly control whether custom kernels are compiled. It defaults to True.
  • Worker Initialization Warning: A warning message is now logged during worker initialization if COMPILE_CUSTOM_KERNELS is set to False, advising that vllm-ascend may not function correctly without custom kernels.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • setup.py
    • Modified build_extensions to conditionally compile custom kernels based on envs.COMPILE_CUSTOM_KERNELS.
    • Updated ext_modules initialization to be conditional on envs.COMPILE_CUSTOM_KERNELS.
  • tests/ut/ops/test_layernorm.py
    • Added @pytest.mark.skip decorator to default_vllm_config due to NPU SocName checking in CANN 8.5.0.
  • tests/ut/ops/test_token_dispatcher.py
    • Imported pytest module.
    • Added @pytest.mark.skip decorator to multiple test methods (test_token_dispatch_without_expert_map, test_token_dispatch_with_expert_map, test_token_dispatch_without_quant, test_token_dispatch_with_quant, test_token_combine_with_expert_map, test_token_combine_without_expert_map, test_token_dispatch_with_router_weight, test_token_dispatch, test_token_combine, test_token_dispatch_with_quant, test_token_dispatch_with_quant_no_active_tokens) due to NPU SocName checking in CANN 8.5.0.
  • tests/ut/test_utils.py
    • Imported pytest module.
    • Added @pytest.mark.skip decorator to test_enable_custom_op due to NPU SocName checking in CANN 8.5.0.
  • vllm_ascend/envs.py
    • Introduced COMPILE_CUSTOM_KERNELS environment variable to control custom kernel compilation, defaulting to True.
  • vllm_ascend/worker/worker.py
    • Added a warning message if COMPILE_CUSTOM_KERNELS is False during worker initialization, indicating potential functional issues.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/_unit_test.yaml
    • .github/workflows/pr_test_light.yaml
Activity
  • The changes were tested on the CI pipeline.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@leo-pony leo-pony marked this pull request as draft February 5, 2026 08:49
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update the CI pipeline to use CANN version 8.5.0. To handle stricter hardware checks in the new version, it introduces a COMPILE_CUSTOM_KERNELS environment variable to conditionally compile custom kernels and skips related unit tests.

While the approach to conditionally compile kernels is sound, the implementation for skipping tests is incorrect. The tests are unconditionally skipped using @pytest.mark.skip, which disables them for all environments and results in a significant loss of test coverage. I've left critical comments on all occurrences, suggesting to use @pytest.mark.skipif to make the skips conditional.

Following the repository's style guide, here are suggestions for the PR title and summary:

Suggested PR Title:

[CI][BugFix] Adapt unit tests for CANN 8.5.0

Suggested PR Summary:

### What this PR does / why we need it?

This PR updates the CANN version for unit tests in the CI pipeline to 8.5.0. The new CANN version introduces stricter NPU SocName checking in `register_kernels`, causing unit tests to fail in CPU-only CI environments.

To resolve this, this PR introduces:
- A `COMPILE_CUSTOM_KERNELS` environment variable to conditionally disable the compilation of custom kernels. This is intended for running unit tests in environments without an NPU.
- Skips for unit tests that depend on custom kernels.

This allows the CI to pass on CPU-only environments with CANN 8.5.0.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Verified on the CI pipeline with the updated CANN version.

Comment thread tests/ut/ops/test_layernorm.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/ops/test_token_dispatcher.py
Comment thread tests/ut/test_utils.py
@leo-pony leo-pony marked this pull request as ready for review February 5, 2026 09:25
@wangxiyuan wangxiyuan merged commit 11339eb into vllm-project:main Feb 6, 2026
14 checks passed
845473182 pushed a commit to 845473182/vllm-ascend that referenced this pull request Feb 6, 2026
…to qwen3next_rebase

* 'main' of https://github.com/vllm-project/vllm-ascend: (59 commits)
  [Feat.]: 310p support MOE models (vllm-project#6530)
  [Doc] backport 0.13.0 release note (vllm-project#6584)
  [CI] Update UT CANN version to 8.5.0 for main branch (vllm-project#6564)
  [CI] Change A2 runner (vllm-project#6557)
  [Bugfix] Fix the incorrect use of the output parameter in _forward_fia_slidingwindow (vllm-project#6469)
  [main2main] upgrade vllm main 0202 (vllm-project#6560)
  [CI][npugraph_ex]Fix npugraph ex e2e test (vllm-project#6553)
  [Feature]KV pool supports sparse attention (vllm-project#6339)
  [bugfix]Fix accuracy issue in PCP/DCP with speculative decoding (vllm-project#6491)
  perf: adaptive block size selection in linear_persistent kernel (vllm-project#6537)
  [ModelRunner][Fix] Pads query_start_loc to satisfy FIA/TND constraint (vllm-project#6475)
  [Bugfix]Fix of Pooling Code and Update of Pooling Usage Guide (vllm-project#6126)
  [Fusion] Add rmsnorm dynamic quant fusion pass (vllm-project#6274)
  [Bugfix] Synchronize only the current stream to avoid device sync (vllm-project#6432)
  [CI] Add long and short prompt tests for DeepSeek-V3.2 (vllm-project#6499)
  [Refactor] MLP weight prefetch to consistency with MoE Model's prefetching in terms of code and usage (vllm-project#6442)
  [bugfix][npugraph_ex]duplicate pattern issue (vllm-project#6513)
  [bugfix][npugraph_ex]add the extra check for allreduce rmsnorm fusion pass (vllm-project#6430)
  [Quant] GLM4.7-Flash Support W8A8 (vllm-project#6492)
  [Nightly][BugFix] Remove kv_cache nz test case for test_mla_preprocess_nq.py (vllm-project#6505)
  ...
chenchuw886 pushed a commit to chenchuw886/vllm-ascend that referenced this pull request Feb 12, 2026
### What this PR does / why we need it?
Update UT CANN version to 8.5.0

### Does this PR introduce _any_ user-facing change?
NA

- vLLM version: v0.15.0
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.15.0

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: momochenchuw <chenchuw@huawei.com>
@wangxiyuan wangxiyuan mentioned this pull request Feb 24, 2026
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
### What this PR does / why we need it?
Update UT CANN version to 8.5.0

### Does this PR introduce _any_ user-facing change?
NA

- vLLM version: v0.15.0
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.15.0

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241 pushed a commit to maoxx241/vllm-ascend that referenced this pull request Mar 2, 2026
### What this PR does / why we need it?
Update UT CANN version to 8.5.0

### Does this PR introduce _any_ user-facing change?
NA


- vLLM version: v0.15.0
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.15.0

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
### What this PR does / why we need it?
Update UT CANN version to 8.5.0

### Does this PR introduce _any_ user-facing change?
NA

- vLLM version: v0.15.0
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.15.0

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 7, 2026
### What this PR does / why we need it?
Update UT CANN version to 8.5.0

### Does this PR introduce _any_ user-facing change?
NA


- vLLM version: v0.15.0
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.15.0

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants