Skip to content

skip pipeline if all changed files are under docs/#180

Merged
khluu merged 3 commits intomainfrom
hl475/skip_pipeline_for_doc_only_changes
Sep 30, 2025
Merged

skip pipeline if all changed files are under docs/#180
khluu merged 3 commits intomainfrom
hl475/skip_pipeline_for_doc_only_changes

Conversation

@hl475
Copy link
Collaborator

@hl475 hl475 commented Sep 30, 2025

Summary

Same as #178 , but directly creating a new branch under vllm-project/ci-infra for easy testing

Test

doc-only case

Use vllm-project/vllm#25819 , and launch a new buildkite https://buildkite.com/vllm/ci/builds/32894/steps/canvas?sid=019998f0-f555-4fe8-ada0-9c91c83cce01

relevant output

[2025-09-30T04:46:36Z] [docs-only] All changes are under docs/. Exiting before pipeline upload.

general case

Use vllm-project/vllm@07be34b , and launch a new buildkite https://buildkite.com/vllm/ci/builds/32915/steps/canvas

Signed-off-by: Huamin Li <3ericli@gmail.com>
@hmellor
Copy link
Member

hmellor commented Sep 30, 2025

Could you please also add a test for a PR which will not trigger docs only mode? (You can cancel the build as soon as the image buils starts)

I just want to see that this won't cause code PRs to insta merge.

@hl475
Copy link
Collaborator Author

hl475 commented Sep 30, 2025

@hmellor - sure, just did one and added into the top test section part!

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm happy with this if you are @khluu

@khluu khluu merged commit 14faf4a into main Sep 30, 2025
1 of 2 checks passed
@hmellor hmellor deleted the hl475/skip_pipeline_for_doc_only_changes branch September 30, 2025 21:52
hmellor added a commit to hmellor/ci-infra that referenced this pull request Sep 30, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
khluu pushed a commit that referenced this pull request Oct 1, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hl475 hl475 mentioned this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants