Merged
Conversation
Signed-off-by: Huamin Li <3ericli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My PR #180 testing is wrong - i used a commit which is already in main to test (which uses get_diff_main instead of get_diff)
Test
Test on PR with changes on both docs and others
vllm-project/vllm#25741
=>
https://buildkite.com/vllm/ci/builds/33142/steps/canvas
Test on PR with changes on docs only
vllm-project/vllm#26024
=>
https://buildkite.com/vllm/ci/builds/33144/steps/canvas
Test on PR with no changes on docs
vllm-project/vllm#26053
=>
https://buildkite.com/vllm/ci/builds/33149/steps/canvas
Test on merge PR with changes on both docs and others
vllm-project/vllm@2f652e6
=>
https://buildkite.com/vllm/ci/builds/33148/steps/canvas
Test on merged PR with changes on docs only
vllm-project/vllm@57b46d7
=>
https://buildkite.com/vllm/ci/builds/33147/steps/canvas
Test on merged PR with no changes on docs
vllm-project/vllm@c36f0aa
=>
https://buildkite.com/vllm/ci/builds/33150/steps/canvas