skip pipeline if all changed files are under docs/#178
skip pipeline if all changed files are under docs/#178hl475 wants to merge 1 commit intovllm-project:mainfrom
Conversation
hl475
force-pushed
the
skip_pipeline_for_doc_only_changes
branch
from
f3c72d1 to
cdbfc46
Compare
khluu
left a comment
khluu
left a comment
There was a problem hiding this comment.
Thanks! Can you test using a PR with only docs changes to see if it works?
buildkite/bootstrap.sh
Outdated
| # ---------------------------------------------------------------------- | ||
|
|
||
| # skip pipeline if all changed files are under docs/ | ||
| if [[ "${DOCS_ONLY_DISABLE}" != "1" && "${RUN_ALL}" != "1" && "${NIGHTLY}" != "1" ]]; then |
There was a problem hiding this comment.
can we just do DOCS_ONLY here?
There was a problem hiding this comment.
absolutely! just updated the PR, thanks!
Signed-off-by: Huamin Li <3ericli@gmail.com>
hl475
force-pushed
the
skip_pipeline_for_doc_only_changes
branch
from
cdbfc46 to
56a909d
Compare
|
Is this different to #177? Should the older PR be reverted if this PR is preferred? |
|
@khluu per instructions from https://github.com/vllm-project/ci-infra?tab=readme-ov-file#how-to-test-changes-in-this-repo, could you please help me add into the repo, so I can create a feature branch? Thanks! |
Yeah, I "think" this PR skips the entire pipeline from bootstrap stage and #177 was done in one step afterwards the stage. I will coordinate with @rzabarazesh to make a decision. |
|
I think prefer this solution as it also skips the image build |
|
I discussed with @rzabarazesh offline for the preference. We will go with this PR and revert the old one once testing is done. |
|
will close this PR and use #180 instead |
3 participants
we could skip the entire pipleine from bootstrap stage if the changes only touching docs