Skip to content

Update docs: VExec no longer a path for Online DDL operations#878

Merged
shlomi-noach merged 6 commits intoprodfrom
update-docs-deperecate-vexec
Nov 22, 2021
Merged

Update docs: VExec no longer a path for Online DDL operations#878
shlomi-noach merged 6 commits intoprodfrom
update-docs-deperecate-vexec

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

Fixes #864

Per vitessio/vitess#9225, vitessio/vitess#9226, vtctl VExec command does not apply any more for Online DDL operations; it is impossible to run queries over schema_migrations table, and all Online DDL operations should go through vtctl OnlineDDL or vtctl ApplySchema.

VExec is still supported for vreplication queries.

This PR should only be merged once vitessio/vitess#9225 and vitessio/vitess#9226 are merged.

cc @hallaroo

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 14, 2021

✔️ Deploy Preview for vitess ready!

🔨 Explore the source changes: 5265ddc

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/6190bec7acf8380007953497

😎 Browse the preview: https://deploy-preview-878--vitess.netlify.app

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 14, 2021

✔️ Deploy Preview for vitess ready!

🔨 Explore the source changes: ceaa242

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/6190bf0c128a510008540236

😎 Browse the preview: https://deploy-preview-878--vitess.netlify.app

@shlomi-noach
Copy link
Copy Markdown
Contributor Author

vitessio/vitess#9225, vitessio/vitess#9226 have been replaced with vitessio/vitess#9227 and vitessio/vitess#9228. We actually restore the full functionality, but we still intend to deprecate use of VExec for Online DDL. We therefore still wish to omit the docs for VExec/OnlineDDL.

@mattlord mattlord self-requested a review November 15, 2021 04:52
@shlomi-noach shlomi-noach marked this pull request as ready for review November 21, 2021 16:03
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

Ready to review!

@shlomi-noach shlomi-noach merged commit 68f016e into prod Nov 22, 2021
@shlomi-noach shlomi-noach deleted the update-docs-deperecate-vexec branch November 22, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove/update vtctl VExec documentation

2 participants