Fix for transactions not allowed to finish during PlannedReparentShard#8089
Merged
systay merged 3 commits intovitessio:masterfrom May 11, 2021
Merged
Fix for transactions not allowed to finish during PlannedReparentShard#8089systay merged 3 commits intovitessio:masterfrom
systay merged 3 commits intovitessio:masterfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…d to serve query Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
reviewed
May 10, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Can you link the previous issue and PR? Is this a straight revert of the previous fix?
Member
Author
|
The fix for the old issue is still inplace. This PR removes the additional check done to retrieve queryservice using tablet alias. |
systay
approved these changes
May 11, 2021
Collaborator
Member
Author
|
Yes, we need to do both the release after merge and backported. |
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
May 11, 2021
Backport of vitessio#8089 This is a combination of 3 commits. * remove precheck of tablet serving and target * remove the additional logic and return error if queryservice not found to serve query * fix test as per new change Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
May 11, 2021
Backport of vitessio#8089 This is a combination of 3 commits. * remove precheck of tablet serving and target * remove the additional logic and return error if queryservice not found to serve query * fix test as per new change Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
deepthi
reviewed
May 13, 2021
Comment on lines
+568
to
+572
| // ChangeTabletType changes the tablet type. | ||
| func (sbc *SandboxConn) ChangeTabletType(typ topodatapb.TabletType) { | ||
| sbc.tablet.Type = typ | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Where is this being used?
systay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a recent fix, an issue was introduced.
Before sending queries to a tablet, #7879 changed the behaviour to check if the tablet is ready to answer, by checking it's
ServingStatusand that the tablet type hasn't changed.If
PlannedReparentShardis going on, this check should not be done for transactions in flight.The vttablet waits for inflight transactions to get
commit/rollbacki.e. we want queries to existing transaction to be sent down to get the transaction completed, even if the tablet is currently saying it isNotServing.The test that exposed this issue was already in the code base:
go/test/endtoend/tabletgateway/buffer/buffer_test.gobecame flaky after #7879 was merged.So, to fix the issue, the pre-check is removed from Gateway when getting the tablet connection for existing active shard_sessions with vttablet.
This also imply that the reserved connection that used to reset based on this pre-check logic will have to hit the vttablet first and then only will reset the shard session on receiving the expected error making it two round trips.
Related Issue(s)
Bug introduced in #7879
Checklist