Addition of waitSig for vtgate/vttablet profiling#121
Merged
frouioui merged 1 commit intovitessio:masterfrom Apr 12, 2021
Merged
Addition of waitSig for vtgate/vttablet profiling#121frouioui merged 1 commit intovitessio:masterfrom
frouioui merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added
Type: Bug
vmg
approved these changes
Apr 9, 2021
systay
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing a vtgate/vttablet configuration issue. The feature implemented in Vitess allowing us to start and stop profile recording at any time using
USR1, PR 7616, was not correctly implemented in arewefastyet's side, resulting in recording starting way too early and finishing at inappropriate times. Thanks @vmg for finding this buggy behavior 🙏🏻